Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213774
Change subject: Always assume a prefix-length of one.
......................................................................
Always assume a prefix-length of one.
Update Echo for I1bf1b8e6d: Make the output of UnifiedDiffFormatter match diff
-u.
Change-Id: I00435a019753f639155df6572844c7112d717186
---
M includes/DiffParser.php
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/74/213774/1
diff --git a/includes/DiffParser.php b/includes/DiffParser.php
index 9f60c36..d18035c 100644
--- a/includes/DiffParser.php
+++ b/includes/DiffParser.php
@@ -77,17 +77,6 @@
* 'left_pos' and 'right_pos' (in 1-indexed lines) of the change.
*/
public function getChangeSet( $leftText, $rightText ) {
- /**
- * The internal diff utility, which is used when GNU diff is
not available
- * prefixes lines with 2 characters instead of 1.
- * For more info see bug 41689.
- */
- if ( self::usingInternalDiff() ) {
- $this->prefixLength = 2;
- } else {
- $this->prefixLength = 1;
- }
-
$left = trim( $leftText ) . "\n";
$right = trim( $rightText ) . "\n";
$diff = wfDiff( $left, $right, '-u -w' );
--
To view, visit https://gerrit.wikimedia.org/r/213774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00435a019753f639155df6572844c7112d717186
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
