Phoenix303 has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213781

Change subject: Sort the group list based on search result count
......................................................................

Sort the group list based on search result count

Changed sortGroups() to compare 'count' value between different groups.
Sorted in descending order.

Bug: T100393
Change-Id: Ie0ff348c698133a2d33b3e7dd55553bfbf66ec7f
---
M resources/js/ext.translate.special.searchtranslations.js
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/81/213781/1

diff --git a/resources/js/ext.translate.special.searchtranslations.js 
b/resources/js/ext.translate.special.searchtranslations.js
index f2b8641..1eb9291 100644
--- a/resources/js/ext.translate.special.searchtranslations.js
+++ b/resources/js/ext.translate.special.searchtranslations.js
@@ -188,6 +188,7 @@
                        options;
 
                level = level || 0;
+               groupList.sort( sortGroups );
                groupList = groupList.splice( 0, maxListSize );
                if ( currentGroup && resultGroups[currentGroup] &&
                        $.inArray( currentGroup, groupList ) < 0
@@ -268,6 +269,7 @@
                        groups = $.map( resultGroups, function ( value, index ) 
{
                                return index;
                        } );
+                       groups.sort( sortGroups );
                        $grouSelectorTrigger.msggroupselector(
                                options,
                                groups
@@ -276,8 +278,8 @@
        }
 
        function sortGroups( groupIdA, groupIdB ) {
-               var groupAName = mw.translate.findGroup( groupIdA, resultGroups 
).label,
-                       groupBName = mw.translate.findGroup( groupIdB, 
resultGroups ).label;
+               var groupAName = mw.translate.findGroup( groupIdA, resultGroups 
).count,
+                       groupBName = mw.translate.findGroup( groupIdB, 
resultGroups ).count;
 
                return groupAName.localeCompare( groupBName );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/213781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0ff348c698133a2d33b3e7dd55553bfbf66ec7f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Phoenix303 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to