Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213995
Change subject: Remove superflous return statement
......................................................................
Remove superflous return statement
Code analysis said that there was a return argument missing, but
SpecialPage::displayRestrictionError() throws a PermissionsError so that
the return statement is not reached.
Change-Id: Iaf83e87ce45224ae6a3fc9bc29577d975879d469
---
M tag/SpecialPageTranslationDeletePage.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/95/213995/1
diff --git a/tag/SpecialPageTranslationDeletePage.php
b/tag/SpecialPageTranslationDeletePage.php
index 3b26e78..10c0acb 100644
--- a/tag/SpecialPageTranslationDeletePage.php
+++ b/tag/SpecialPageTranslationDeletePage.php
@@ -133,7 +133,6 @@
# Check rights
if ( !$this->userCanExecute( $this->getUser() ) ) {
$this->displayRestrictionError();
- return;
}
if ( $this->title === null ) {
--
To view, visit https://gerrit.wikimedia.org/r/213995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf83e87ce45224ae6a3fc9bc29577d975879d469
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
