Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214059
Change subject: Use default LightnCandy handlebars directive
......................................................................
Use default LightnCandy handlebars directive
We no longer have to specifically list all-but-one handlebars directives,
the proper fix for that one directive has already landed into the
LightnCandy version we're using.
Change-Id: I9246d2c49ac27ff673dde26618276f806b421bbf
---
M includes/TemplateHelper.php
1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/59/214059/1
diff --git a/includes/TemplateHelper.php b/includes/TemplateHelper.php
index 17f9b78..0241c37 100644
--- a/includes/TemplateHelper.php
+++ b/includes/TemplateHelper.php
@@ -126,14 +126,7 @@
'flags' => LightnCandy::FLAG_ERROR_EXCEPTION
| LightnCandy::FLAG_EXTHELPER
| LightnCandy::FLAG_SPVARS
- // Commented
LightnCandy::FLAG_HANDLEBARS because it includes
- // FLAG_MUSTACHEPAIN, which currently
causes issues. Below
- // line can be uncommented & the one
below (spelling out all
- // options excluding FLAG_MUSTACHEPAIN)
can be removed once
- //
https://github.com/zordius/lightncandy/pull/126 or similar
- // lands.
-// | LightnCandy::FLAG_HANDLEBARS //
FLAG_THIS + FLAG_WITH + FLAG_PARENT + FLAG_JSQUOTE + FLAG_ADVARNAME +
FLAG_SPACECTL + FLAG_NAMEDARG + FLAG_SPVARS + FLAG_SLASH + FLAG_ELSE +
FLAG_MUSTACHESP + FLAG_MUSTACHEPAIN
- | LightnCandy::FLAG_THIS |
LightnCandy::FLAG_WITH | LightnCandy::FLAG_PARENT | LightnCandy::FLAG_JSQUOTE |
LightnCandy::FLAG_ADVARNAME | LightnCandy::FLAG_SPACECTL |
LightnCandy::FLAG_NAMEDARG | LightnCandy::FLAG_SPVARS | LightnCandy::FLAG_SLASH
| LightnCandy::FLAG_ELSE | LightnCandy::FLAG_MUSTACHESP
+ | LightnCandy::FLAG_HANDLEBARS
| LightnCandy::FLAG_RUNTIMEPARTIAL,
'basedir' => array( $templateDir ),
'fileext' => array( '.partial.handlebars' ),
--
To view, visit https://gerrit.wikimedia.org/r/214059
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9246d2c49ac27ff673dde26618276f806b421bbf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
