jenkins-bot has submitted this change and it was merged.
Change subject: SpecialOAuthLogin.php/init: Removing !$status->isGood() error
handling
......................................................................
SpecialOAuthLogin.php/init: Removing !$status->isGood() error handling
$status is not defined within init subpage
Bug: T100020
Change-Id: I5a6ccab4c89912cffe54b51e20a0e2bf4165c3bd
---
M specials/SpecialOAuthLogin.php
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
CSteipp: Looks good to me, approved
jenkins-bot: Verified
diff --git a/specials/SpecialOAuthLogin.php b/specials/SpecialOAuthLogin.php
index c427e7a..010ce0b 100644
--- a/specials/SpecialOAuthLogin.php
+++ b/specials/SpecialOAuthLogin.php
@@ -50,9 +50,6 @@
} catch ( Exception $e ) {
throw new \ErrorPageError(
'oauthauth-error', $e->getMessage() );
}
- if ( !$status->isGood() ) {
- throw new \ErrorPageError(
'oauthauth-error', $status->getMessage() );
- }
break;
case 'finish':
--
To view, visit https://gerrit.wikimedia.org/r/212785
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a6ccab4c89912cffe54b51e20a0e2bf4165c3bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuthAuthentication
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Zhuyifei1999 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
