Mholloway has submitted this change and it was merged.
Change subject: Fix TextView directionality issue for mixed LTR and RTL strings
......................................................................
Fix TextView directionality issue for mixed LTR and RTL strings
Some TextViews are displaying mixed LTR and RTL text incorrectly, formatting
it as if it's an LTR string, which results in incorrect display. This patch
fixes those TextViews to display as appropriate. Note: the fix was confirmed
to be the correct way of displying mixed text by a Hebrew speaker (Matanya
on the Phabricator task.
Bug: T97958
Change-Id: Idec520cbc9ee8db8d691c2f487d2bfd0042f7bae
---
M wikipedia/res/layout/fragment_page.xml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Mholloway: Looks good to me, approved
Niedzielski: Looks good to me, but someone else must approve
Objections:
BearND: There's a problem with this change, please improve
diff --git a/wikipedia/res/layout/fragment_page.xml
b/wikipedia/res/layout/fragment_page.xml
index 8dd0598..bcfba64 100644
--- a/wikipedia/res/layout/fragment_page.xml
+++ b/wikipedia/res/layout/fragment_page.xml
@@ -68,6 +68,7 @@
android:layout_height="wrap_content"
android:textIsSelectable="true"
android:fontFamily="serif"
+ android:textDirection="anyRtl"
android:paddingTop="16dp"
android:paddingBottom="16dp"
android:paddingRight="@dimen/activity_horizontal_margin"
@@ -80,6 +81,7 @@
android:visibility="invisible"
android:textIsSelectable="true"
android:fontFamily="serif"
+ android:textDirection="anyRtl"
android:textSize="@dimen/descriptionTextSize"
android:paddingBottom="16dp"
android:paddingRight="@dimen/activity_horizontal_margin"
--
To view, visit https://gerrit.wikimedia.org/r/208567
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idec520cbc9ee8db8d691c2f487d2bfd0042f7bae
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Deskana <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Deskana <[email protected]>
Gerrit-Reviewer: Matanya <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
