XZise has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/214423

Change subject: [FIX] APISite.upload: Expect a dict not a list
......................................................................

[FIX] APISite.upload: Expect a dict not a list

The imageinfo returned via query+imageinfo is a list while the imageinfo
returned via upload is just a dict. Since 31cd9fdc it assumed it returned
actually a list of dicts and thus failed when FileInfo tried to create itself
from a part of the dict.

Change-Id: I0a31451fee3ac342a748c6b03fea9e9853cefd7f
---
M pywikibot/site.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/23/214423/1

diff --git a/pywikibot/site.py b/pywikibot/site.py
index ebcd71d..939fa58 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -5090,7 +5090,7 @@
             # If we receive a nochange, that would mean we're in simulation
             # mode, don't attempt to access imageinfo
             if "nochange" not in result:
-                filepage._load_file_revisions(result["imageinfo"])
+                filepage._load_file_revisions([result["imageinfo"]])
             return
 
     @deprecated_args(number="step",

-- 
To view, visit https://gerrit.wikimedia.org/r/214423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a31451fee3ac342a748c6b03fea9e9853cefd7f
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: XZise <commodorefabia...@gmx.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to