Mholloway has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214491
Change subject: Don't display confirmation dialog before refreshing saved pages
......................................................................
Don't display confirmation dialog before refreshing saved pages
Down with unnecessary confirmation dialogs before non-destructive tasks!
Bug: T69057
Change-Id: I4f6b386c650a2a27e49f9e9c83aa3429787d8928
---
M wikipedia/res/values-qq/strings.xml
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
3 files changed, 1 insertion(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/91/214491/1
diff --git a/wikipedia/res/values-qq/strings.xml
b/wikipedia/res/values-qq/strings.xml
index d8ec7c3..f5bf5b8 100644
--- a/wikipedia/res/values-qq/strings.xml
+++ b/wikipedia/res/values-qq/strings.xml
@@ -34,7 +34,6 @@
{{Identical|Update saved page}}</string>
<string name="menu_update_selected_saved_pages">Menu item (icon) in saved
pages screen to update selected saved pages.
{{Identical|Update saved page}}</string>
- <string name="dialog_prompt_refresh_all_saved_pages">Prompt before updating
all saved pages</string>
<string name="menu_save_page">Menu item text for saving the currently active
page.
{{Identical|Save page}}</string>
<string name="menu_share_page">Menu item text for sharing the currently
active page. Uses the build-in Android sharing functionality, so translate it
the same way as the operating system does.
diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index fa1ec40..de13a05 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -27,7 +27,6 @@
<string name="nav_item_saved_pages">Saved pages</string>
<string name="menu_update_all_saved_pages">Update saved pages</string>
<string name="menu_update_selected_saved_pages">Update saved pages</string>
- <string name="dialog_prompt_refresh_all_saved_pages">Update all saved
pages?</string>
<string name="menu_save_page">Save page</string>
<string name="menu_share_page">Share</string>
<string name="share_via">Share via</string>
diff --git
a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
index df493eb..105080d 100644
--- a/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/savedpages/SavedPagesFragment.java
@@ -326,7 +326,7 @@
case android.R.id.home:
return false;
case R.id.menu_refresh_all_saved_pages:
- promptToRefreshAll();
+ refreshAll();
return true;
case R.id.menu_clear_all_saved_pages:
promptToDeleteAll();
@@ -334,19 +334,6 @@
default:
throw new RuntimeException("Unknown menu item clicked!");
}
- }
-
- private void promptToRefreshAll() {
- AlertDialog.Builder builder = new AlertDialog.Builder(getActivity());
- builder.setMessage(R.string.dialog_prompt_refresh_all_saved_pages);
- builder.setPositiveButton(R.string.yes, new
DialogInterface.OnClickListener() {
- @Override
- public void onClick(DialogInterface dialog, int which) {
- refreshAll();
- }
- });
- builder.setNegativeButton(R.string.no, null);
- builder.create().show();
}
private void promptToDeleteAll() {
--
To view, visit https://gerrit.wikimedia.org/r/214491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f6b386c650a2a27e49f9e9c83aa3429787d8928
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
