Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214519
Change subject: Remove the DummyPropertyInfoStore
......................................................................
Remove the DummyPropertyInfoStore
No longer used.
Change-Id: I7ae7a1223d9c5c03bce580eed047d31b4308eeda
---
D lib/includes/store/DummyPropertyInfoStore.php
D lib/tests/phpunit/store/DummyPropertyInfoStoreTest.php
2 files changed, 0 insertions(+), 126 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/19/214519/1
diff --git a/lib/includes/store/DummyPropertyInfoStore.php
b/lib/includes/store/DummyPropertyInfoStore.php
deleted file mode 100644
index 09c6504..0000000
--- a/lib/includes/store/DummyPropertyInfoStore.php
+++ /dev/null
@@ -1,70 +0,0 @@
-<?php
-
-namespace Wikibase;
-
-use Wikibase\DataModel\Entity\PropertyId;
-
-/**
- * Class DummyPropertyInfoStore is an implementation of PropertyInfoStore
- * that does nothing.
- *
- * @since 0.4
- *
- * @license GPL 2+
- * @author Daniel Kinzler
- */
-class DummyPropertyInfoStore implements PropertyInfoStore {
-
- /**
- * @see PropertyInfoStore::getPropertyInfo
- *
- * @param PropertyId $propertyId
- *
- * @return null
- */
- public function getPropertyInfo( PropertyId $propertyId ) {
- return null;
- }
-
- /**
- * @see PropertyInfoStore::getPropertyInfoForDataType
- *
- * @param string $dataType
- *
- * @return array[]
- */
- public function getPropertyInfoForDataType( $dataType ) {
- return array();
- }
-
- /**
- * @see PropertyInfoStore::getAllPropertyInfo
- *
- * @return array[]
- */
- public function getAllPropertyInfo() {
- return array();
- }
-
- /**
- * @see PropertyInfoStore::setPropertyInfo
- *
- * @param PropertyId $propertyId
- * @param array $info
- */
- public function setPropertyInfo( PropertyId $propertyId, array $info ) {
- // noop
- }
-
- /**
- * @see PropertyInfoStore::removePropertyInfo
- *
- * @param PropertyId $propertyId
- *
- * @return bool false
- */
- public function removePropertyInfo( PropertyId $propertyId ) {
- return false;
- }
-
-}
\ No newline at end of file
diff --git a/lib/tests/phpunit/store/DummyPropertyInfoStoreTest.php
b/lib/tests/phpunit/store/DummyPropertyInfoStoreTest.php
deleted file mode 100644
index faa8ed2..0000000
--- a/lib/tests/phpunit/store/DummyPropertyInfoStoreTest.php
+++ /dev/null
@@ -1,56 +0,0 @@
-<?php
-
-namespace Wikibase\Test;
-
-use Wikibase\DataModel\Entity\PropertyId;
-use Wikibase\DummyPropertyInfoStore;
-use Wikibase\PropertyInfoStore;
-
-/**
- * @covers Wikibase\DummyPropertyInfoStore
- *
- * @group Wikibase
- * @group WikibaseLib
- * @group WikibasePropertyInfo
- * @group WikibaseStore
- *
- * @licence GNU GPL v2+
- * @author Daniel Kinzler
- */
-class DummyPropertyInfoStoreTest extends \MediaWikiTestCase {
-
- public function newDummyPropertyInfoStore() {
- return new DummyPropertyInfoStore();
- }
-
- public function testSetPropertyInfo() {
- $store = $this->newDummyPropertyInfoStore();
- $p23 = new PropertyId( 'P23' );
- $info23 = array( PropertyInfoStore::KEY_DATA_TYPE => 'string' );
-
- // just check that there's no exception
- $store->setPropertyInfo( $p23, $info23 );
- $this->assertTrue( true ); // dummy
- }
-
- public function testGetPropertyInfo() {
- $store = $this->newDummyPropertyInfoStore();
- $p23 = new PropertyId( 'P23' );
-
- $this->assertNull( $store->getPropertyInfo( $p23 ) );
- }
-
- public function testGetAllPropertyInfo() {
- $store = $this->newDummyPropertyInfoStore();
-
- $this->assertCount( 0, $store->getAllPropertyInfo() );
- }
-
- public function testRemovePropertyInfo() {
- $store = $this->newDummyPropertyInfoStore();
- $p23 = new PropertyId( 'P23' );
-
- $this->assertFalse( $store->removePropertyInfo( $p23 ) );
- }
-
-}
--
To view, visit https://gerrit.wikimedia.org/r/214519
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ae7a1223d9c5c03bce580eed047d31b4308eeda
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
