Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/214895
Change subject: WikidataPageBanner add option caption
......................................................................
WikidataPageBanner add option caption
Add parameter 'caption' to {{PAGEBANNER}} function, which will display a caption
on the banner image as a tooltip.
Depends on I1e67311e76c66c26bd8b1f2dc22856dffd98c99a
Bug: T100486
Change-Id: I2acffb73ba6d28fd72fe13cae26384a29b15fbae
---
M includes/WikidataPageBanner.hooks.php
M templates/banner.mustache
2 files changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/95/214895/1
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 522cc0e..4a02028 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -73,6 +73,9 @@
$title = $parser->getTitle();
$ns = $title->getNamespace();
if ( in_array( $ns, $wgBannerNamespaces ) &&
!$title->isMainPage() ) {
+ if ( isset( $opts['caption'] ) ) {
+ $params['caption'] = $opts['caption'];
+ }
$banner = self::getBannerHtml( $fileurl, $title );
// Set 'articlebanner' property for future reference
$parser->getOutput()->setProperty( 'articlebanner',
$banner );
diff --git a/templates/banner.mustache b/templates/banner.mustache
index cec3226..8909f1e 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -1,5 +1,5 @@
<div class="noprint">
- <div class="ext-wpb-pagebanner"
style="background-image:url({{banner}})">
+ <div title={{caption}} class="ext-wpb-pagebanner"
style="background-image:url({{banner}})">
<div class="topbanner">
<div class="name">{{title}}</div>
<div class="iconbox"></div>
--
To view, visit https://gerrit.wikimedia.org/r/214895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2acffb73ba6d28fd72fe13cae26384a29b15fbae
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
