Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/215344

Change subject: Avoid exception when switching modes in demo
......................................................................

Avoid exception when switching modes in demo

Change-Id: I6cf3070babc0fa812ae0b1d43a5202eb6a4c94fa
---
M demos/ve/ve.demo.SurfaceContainer.js
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor 
refs/changes/44/215344/1

diff --git a/demos/ve/ve.demo.SurfaceContainer.js 
b/demos/ve/ve.demo.SurfaceContainer.js
index 7a628f8..6e90ac1 100644
--- a/demos/ve/ve.demo.SurfaceContainer.js
+++ b/demos/ve/ve.demo.SurfaceContainer.js
@@ -257,7 +257,10 @@
 
        this.$surfaceWrapper.empty().append( this.surface.$element.parent() )
                .hide().slideDown().promise().done( function () {
-                       container.surface.getView().focus();
+                       // Check surface still exists
+                       if ( container.surface ) {
+                               container.surface.getView().focus();
+                       }
                } );
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/215344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6cf3070babc0fa812ae0b1d43a5202eb6a4c94fa
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to