Ori.livneh has submitted this change and it was merged.

Change subject: HHVM APC: enable item expiration
......................................................................


HHVM APC: enable item expiration

HHVM won't ever purge expired keys from APC unless
Server.APC.ExpireOnSets=true. It is set to false by default.
When true, HHVM will iterate on expired keys and evict them from
APC once every 4096 APC writes by default.

Change-Id: I87047dac97cb3bed0dfffd714b18be2b941f4de3
---
M modules/hhvm/manifests/init.pp
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Ori.livneh: Verified; Looks good to me, approved
  Aaron Schulz: Looks good to me, but someone else must approve
  Rush: Looks good to me, but someone else must approve



diff --git a/modules/hhvm/manifests/init.pp b/modules/hhvm/manifests/init.pp
index 9d64589..c070bb3 100644
--- a/modules/hhvm/manifests/init.pp
+++ b/modules/hhvm/manifests/init.pp
@@ -112,6 +112,9 @@
             pid_file                 => '',  # PID file managed by 
start-stop-daemon(8)
             resource_limit           => { core_file_size => to_bytes('8 Gb') },
             timeouts_use_wall_time   => true,
+            apc                      => {
+                expire_on_sets     => true,  # Purge on expiration
+            },
             log                      => {
                 header             => true,
                 use_syslog         => true,

-- 
To view, visit https://gerrit.wikimedia.org/r/215213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I87047dac97cb3bed0dfffd714b18be2b941f4de3
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Rush <r...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to