Sbisson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215664
Change subject: Fix new talk page message notification
......................................................................
Fix new talk page message notification
* Do not default section to footer. If the section
is not found, it is left empty and the notification
message is simpler.
* Change notification-edit-talk-page-email-batch-body2
Replace : at the end with . so it does not look
incomplete.
Bug: T99989
Change-Id: Ic982a81eada388d750760787245dea8f72368147
---
M i18n/en.json
M includes/DiscussionParser.php
2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/64/215664/1
diff --git a/i18n/en.json b/i18n/en.json
index 8e7151f..427c302 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -77,7 +77,7 @@
"notification-reverted2": "Your {{PLURAL:$4|edit on [[:$2]] has|edits
on [[:$2]] have}} been {{GENDER:$1|reverted}} by [[User:$1|$1]]. $3",
"notification-reverted-flyout2": "Your {{PLURAL:$4|edit on $2 has|edits
on $2 have}} been {{GENDER:$1|reverted}} by $1. $3",
"notification-edit-talk-page-email-subject2": "$1 {{GENDER:$1|left}}
you a message on {{SITENAME}}",
- "notification-edit-talk-page-email-batch-body2": "$1 {{GENDER:$1|left}}
a message on your talk page:",
+ "notification-edit-talk-page-email-batch-body2": "$1 {{GENDER:$1|left}}
a message on your talk page.",
"notification-edit-talk-page-email-batch-body-with-section": "$1
{{GENDER:$1|left}} a message on your talk page in \"$2\".",
"notification-page-linked-email-subject": "A page you created was
linked on {{SITENAME}}",
"notification-page-linked-email-batch-body": "$2 was
{{GENDER:$1|linked}} from $3.",
diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index 09b5bcf..5c1cb57 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -55,9 +55,6 @@
// if this is a minor edit, only notify if the
agent doesn't have talk page minor edit notification blocked
if ( !$revision->isMinor() ||
!$user->isAllowed( 'nominornewtalk' ) ) {
$section =
self::detectSectionTitleAndText( $interpretation, $title );
- if ( $section['section-title'] === '' )
{
- $section['section-title'] =
'footer';
- }
if ( $section['section-text'] === '' ) {
$section['section-text'] =
$revision->getComment();
}
--
To view, visit https://gerrit.wikimedia.org/r/215664
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic982a81eada388d750760787245dea8f72368147
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Sbisson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
