Subramanya Sastry has submitted this change and it was merged. Change subject: Expand attribute tokens before converting them back to plain tokens ......................................................................
Expand attribute tokens before converting them back to plain tokens * Expand template attribute tokens when switching a template with invalid target back to regular content. * Remove ParserValue handling from flattenAndAppendToks- ParserValues should not get there really. Should we explicitly test for them and throw an exception in the interest of fail early & loud? This fixes crashes like http://parsoid.wmflabs.org:8001/result/684a25a1be457727593ac816e894d8acdec9f4cc/Georgetown%20Pike. No change in parser tests (TODO: add parser test). Change-Id: I543aaefa0b0bdd9be9ba1a6fe49c1fd3e5ef5c41 --- M js/lib/ext.core.TemplateHandler.js M js/lib/mediawiki.Util.js 2 files changed, 56 insertions(+), 23 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35792 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I543aaefa0b0bdd9be9ba1a6fe49c1fd3e5ef5c41 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: GWicke <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> Gerrit-Reviewer: Subramanya Sastry <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
