jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.searchSuggest: Add track event on search form
submission
......................................................................
mediawiki.searchSuggest: Add track event on search form submission
Only fired from the skin-provided search box currently.
Bug: T97310
Change-Id: Iaccacdabca427afe1c1d5c42ae6d18d19a70543b
---
M resources/src/mediawiki/mediawiki.searchSuggest.js
1 file changed, 11 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
Deskana: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/src/mediawiki/mediawiki.searchSuggest.js
b/resources/src/mediawiki/mediawiki.searchSuggest.js
index f981b90..1f3b123 100644
--- a/resources/src/mediawiki/mediawiki.searchSuggest.js
+++ b/resources/src/mediawiki/mediawiki.searchSuggest.js
@@ -247,8 +247,17 @@
$region: $searchRegion
} );
- // If the form includes any fallback fulltext search buttons,
remove them
- $searchInput.closest( 'form' ).find( '.mw-fallbackSearchButton'
).remove();
+ $searchInput.closest( 'form' )
+ // track the form submit event
+ .on( 'submit', function () {
+ var context = $searchInput.data(
'suggestionsContext' );
+ mw.track( 'mediawiki.searchSuggest', {
+ action: 'submit-form',
+ numberOfResults:
context.config.suggestions.length
+ } );
+ } )
+ // If the form includes any fallback fulltext search
buttons, remove them
+ .find( '.mw-fallbackSearchButton' ).remove();
} );
}( mediaWiki, jQuery ) );
--
To view, visit https://gerrit.wikimedia.org/r/207262
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaccacdabca427afe1c1d5c42ae6d18d19a70543b
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Deskana <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
