Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/215917
Change subject: Revert "Add 'mediawiki.skinning.logo' module"
......................................................................
Revert "Add 'mediawiki.skinning.logo' module"
This is redundant and creates more modules than necessary.
The use case of not wanting to load "mediawiki.skinning.interface"
in a custom skin is invalid. For this exact purpose we already created
the ResourceLoaderSkinModule class which is generic and re-usable.
Skins can add that class name to their stylesheet file module to
append the logo styles. This way involves no extra modules. Not in
core, and not in any skin.
This reverts commit 43346e1527dc6f30e33c5acd4f479acc0eab7d0a.
Change-Id: I2b0a1d5ed72f2d5338ad26af6e04227bec45dcc1
---
M resources/Resources.php
1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/17/215917/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 7b7a31c..844f232 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -109,7 +109,6 @@
// Used in the web installer. Test it after modifying this definition!
'mediawiki.skinning.interface' => array(
'position' => 'top',
- // Display wiki logo on .mw-wiki-logo elements.
'class' => 'ResourceLoaderSkinModule',
'styles' => array(
'resources/src/mediawiki.skinning/elements.css' =>
array( 'media' => 'screen' ),
@@ -134,13 +133,6 @@
'styles' => array(
'resources/src/mediawiki.skinning/content.externallinks.css' => array( 'media'
=> 'screen' ),
),
- ),
-
- // Display wiki logo on .mw-wiki-logo elements.
- // This is also part of 'mediawiki.skinning.interface' module; the skin
shouldn't load them both.
- 'mediawiki.skinning.logo' => array(
- 'position' => 'top',
- 'class' => 'ResourceLoaderSkinModule',
),
/* jQuery */
--
To view, visit https://gerrit.wikimedia.org/r/215917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b0a1d5ed72f2d5338ad26af6e04227bec45dcc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
