jenkins-bot has submitted this change and it was merged. Change subject: Use a faster 7z command line by default ......................................................................
Use a faster 7z command line by default In tests with one typical XML dump, -mx=4 looked much better than -mx=5 in terms of CPU cost, with negligible losses in compression. Merged downstream by Wikia: https://github.com/Wikia/app/pull/6118 It probably makes sense to explicitly adopt a default suitable for XML dumps; but later this should be configurable in scripts etc. (T78669). Change-Id: I07ab5f93ecd6d706460691db5181de89ef31cbea --- M includes/Export.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Legoktm: Looks good to me, approved ArielGlenn: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/Export.php b/includes/Export.php index 4600feb..0d55d7d 100644 --- a/includes/Export.php +++ b/includes/Export.php @@ -1191,7 +1191,7 @@ * @return string */ function setup7zCommand( $file ) { - $command = "7za a -bd -si " . wfEscapeShellArg( $file ); + $command = "7za a -bd -si -mx=4 " . wfEscapeShellArg( $file ); // Suppress annoying useless crap from p7zip // Unfortunately this could suppress real error messages too $command .= ' >' . wfGetNull() . ' 2>&1'; -- To view, visit https://gerrit.wikimedia.org/r/186347 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07ab5f93ecd6d706460691db5181de89ef31cbea Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Nemo bis <[email protected]> Gerrit-Reviewer: ArielGlenn <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Nemo bis <[email protected]> Gerrit-Reviewer: TTO <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
