Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216108
Change subject: Fix phpcs warnings in WikidataPageBanner
......................................................................
Fix phpcs warnings in WikidataPageBanner
Remove unused $wgScript and $wgStandardSizes from WikidataPageBanner.hooks.php.
Fix line 'exceeding 100 characters' on lines 43,44 in WikidataPageBanner.php.
Bug: T101293
Change-Id: I6c048dda865acc11d7dc32b1d092e105d1e09ec2
---
M WikidataPageBanner.php
M includes/WikidataPageBanner.hooks.php
2 files changed, 6 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/08/216108/1
diff --git a/WikidataPageBanner.php b/WikidataPageBanner.php
index 4a54658..c71b4d9 100644
--- a/WikidataPageBanner.php
+++ b/WikidataPageBanner.php
@@ -40,8 +40,10 @@
// Register files
$wgMessagesDirs['WikidataPageBanner'] = __DIR__ . '/i18n';
-$wgExtensionMessagesFiles['WikidataPageBannerAlias'] = __DIR__ .
'/WikidataPageBanner.i18n.alias.php';
-$wgExtensionMessagesFiles['WikidataPageBannerMagic'] = __DIR__ .
'/WikidataPageBanner.i18n.magic.php';
+$wgExtensionMessagesFiles['WikidataPageBannerAlias'] =
+ __DIR__ . '/WikidataPageBanner.i18n.alias.php';
+$wgExtensionMessagesFiles['WikidataPageBannerMagic'] =
+ __DIR__ . '/WikidataPageBanner.i18n.magic.php';
// Register hooks
// Hook to inject banner code
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index 770ef8b..0b3b909 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -65,7 +65,7 @@
* @return output
*/
public static function addCustomBanner( $parser, $bannername ) {
- global $wgBannerNamespaces, $wgStandardSizes;
+ global $wgBannerNamespaces;
$banner = '';
$title = $parser->getTitle();
$ns = $title->getNamespace();
@@ -126,7 +126,7 @@
* @return string|null Html code of the banner or null if invalid
bannername
*/
public static function getBannerHtml( $title, $bannername ) {
- global $wgStandardSizes, $wgScript, $wgArticlePath;
+ global $wgStandardSizes, $wgArticlePath;
$urls = self::getStandardSizeUrls( $bannername );
$banner = null;
/** @var String srcset attribute for <img> element of banner
image */
--
To view, visit https://gerrit.wikimedia.org/r/216108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c048dda865acc11d7dc32b1d092e105d1e09ec2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
