Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/216659
Change subject: Rename ChangeOpClaimRemove to ChangeOpStatementRemove
......................................................................
Rename ChangeOpClaimRemove to ChangeOpStatementRemove
As requested by Addshore in Id8361ad.
Bug: T87388
Change-Id: Ie32a8dfa7ebae1f4b093d927202a233e11de3e16
---
R repo/includes/ChangeOp/ChangeOpStatementRemove.php
M repo/includes/ChangeOp/ClaimChangeOpFactory.php
R repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRemoveTest.php
3 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/59/216659/1
diff --git a/repo/includes/ChangeOp/ChangeOpClaimRemove.php
b/repo/includes/ChangeOp/ChangeOpStatementRemove.php
similarity index 97%
rename from repo/includes/ChangeOp/ChangeOpClaimRemove.php
rename to repo/includes/ChangeOp/ChangeOpStatementRemove.php
index f9be42e..812789c 100644
--- a/repo/includes/ChangeOp/ChangeOpClaimRemove.php
+++ b/repo/includes/ChangeOp/ChangeOpStatementRemove.php
@@ -21,7 +21,7 @@
* @author Adam Shorland
* @author Thiemo Mättig
*/
-class ChangeOpClaimRemove extends ChangeOpBase {
+class ChangeOpStatementRemove extends ChangeOpBase {
/**
* @var string
@@ -31,7 +31,7 @@
/**
* @return string
*/
- public function getClaimGuid() {
+ public function getStatementGuid() {
return $this->guid;
}
diff --git a/repo/includes/ChangeOp/ClaimChangeOpFactory.php
b/repo/includes/ChangeOp/ClaimChangeOpFactory.php
index 026de21..aa05a48 100644
--- a/repo/includes/ChangeOp/ClaimChangeOpFactory.php
+++ b/repo/includes/ChangeOp/ClaimChangeOpFactory.php
@@ -101,7 +101,7 @@
* @return ChangeOp
*/
public function newRemoveClaimOp( $claimGuid ) {
- return new ChangeOpClaimRemove( $claimGuid );
+ return new ChangeOpStatementRemove( $claimGuid );
}
/**
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRemoveTest.php
similarity index 74%
rename from repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php
rename to repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRemoveTest.php
index 7c37145..430fcad 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpClaimRemoveTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRemoveTest.php
@@ -5,7 +5,7 @@
use DataValues\DataValue;
use DataValues\StringValue;
use InvalidArgumentException;
-use Wikibase\ChangeOp\ChangeOpClaimRemove;
+use Wikibase\ChangeOp\ChangeOpStatementRemove;
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
@@ -13,7 +13,7 @@
use Wikibase\DataModel\Statement\Statement;
/**
- * @covers Wikibase\ChangeOp\ChangeOpClaimRemove
+ * @covers Wikibase\ChangeOp\ChangeOpStatementRemove
*
* @group Wikibase
* @group WikibaseRepo
@@ -22,7 +22,7 @@
* @licence GNU GPL v2+
* @author Adam Shorland
*/
-class ChangeOpClaimRemoveTest extends \PHPUnit_Framework_TestCase {
+class ChangeOpStatementRemoveTest extends \PHPUnit_Framework_TestCase {
public function invalidConstructorProvider() {
$args = array();
@@ -36,13 +36,13 @@
* @expectedException InvalidArgumentException
*/
public function testInvalidConstruct( $claimGuid ) {
- new ChangeOpClaimRemove( $claimGuid );
+ new ChangeOpStatementRemove( $claimGuid );
}
public function testGetClaimGuid() {
$claimguid = 'foobar';
- $changeop = new ChangeOpClaimRemove( $claimguid );
- $this->assertEquals( $claimguid, $changeop->getClaimGuid() );
+ $changeop = new ChangeOpStatementRemove( $claimguid );
+ $this->assertEquals( $claimguid, $changeop->getStatementGuid()
);
}
public function changeOpProvider() {
@@ -54,7 +54,7 @@
/** @var Statement $statement */
$statement = reset( $statements );
$guid = $statement->getGuid();
- $changeOp = new ChangeOpClaimRemove( $guid );
+ $changeOp = new ChangeOpStatementRemove( $guid );
$expected = null;
$args[] = array ( $item, $changeOp, $expected );
@@ -64,11 +64,11 @@
/**
* @dataProvider changeOpProvider
*/
- public function testApplyAddNewClaim( Item $item, ChangeOpClaimRemove
$changeOp, DataValue $expected = null ) {
+ public function testApplyAddNewClaim( Item $item,
ChangeOpStatementRemove $changeOp, DataValue $expected = null ) {
$this->assertTrue( $changeOp->apply( $item ), "Applying the
ChangeOp did not return true" );
- $this->assertNotEmpty( $changeOp->getClaimGuid() );
+ $this->assertNotEmpty( $changeOp->getStatementGuid() );
$claims = new Claims( $item->getClaims() );
- $this->assertEquals( $expected, $claims->getClaimWithGuid(
$changeOp->getClaimGuid() ) );
+ $this->assertEquals( $expected, $claims->getClaimWithGuid(
$changeOp->getStatementGuid() ) );
}
private function newItemWithClaim( $itemIdString, $snak ) {
--
To view, visit https://gerrit.wikimedia.org/r/216659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie32a8dfa7ebae1f4b093d927202a233e11de3e16
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
