jenkins-bot has submitted this change and it was merged.
Change subject: Fix conditional deed step skipping for Flickr
......................................................................
Fix conditional deed step skipping for Flickr
Bug: T101616
Change-Id: I9f590448c5a4ff648555e740d2486ed148647613
(cherry picked from commit abdee19d9dc232a3479ff668c4a22a87fe691147)
---
M resources/controller/uw.controller.Deed.js
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
MarkTraceur: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/controller/uw.controller.Deed.js
b/resources/controller/uw.controller.Deed.js
index bb9a00f..38915b1 100644
--- a/resources/controller/uw.controller.Deed.js
+++ b/resources/controller/uw.controller.Deed.js
@@ -40,7 +40,12 @@
DP = Deed.prototype;
DP.moveFrom = function () {
- var valid = this.deedChooser.valid();
+ var valid = true;
+
+ if ( this.deedChooser ) {
+ valid = this.deedChooser.valid();
+ }
+
// validate has the side effect of notifying the user of
problems, or removing existing notifications.
// if returns false, you can assume there are notifications in
the interface.
if ( valid ) {
--
To view, visit https://gerrit.wikimedia.org/r/216720
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f590448c5a4ff648555e740d2486ed148647613
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: wmf/1.26wmf8
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
