Filippo Giunchedi has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/216892

Change subject: restbase: fix graphite description
......................................................................

restbase: fix graphite description

icinga/nagios don't like commas in descriptions

Bug: T78514
Change-Id: Id234d710e4bf8252dcc16551636314ea1c21cf91
---
M manifests/role/restbase.pp
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/92/216892/1

diff --git a/manifests/role/restbase.pp b/manifests/role/restbase.pp
index 079eb83..bdb7cb6 100644
--- a/manifests/role/restbase.pp
+++ b/manifests/role/restbase.pp
@@ -22,7 +22,7 @@
 
 class role::restbase::alerts {
     monitoring::graphite_threshold { 'restbase_request_5xx_rate':
-        description    => 'RESTBase requests returning 5xx, in req/s',
+        description    => 'RESTBase req/s returning 5xx',
         metric         => 
'restbase.v1_page_html_-title-_-revision--_tid-.GET.5xx.sample_rate',
         from           => '10min',
         warning        => '1', # 1 5xx/s
@@ -32,7 +32,7 @@
     }
 
     monitoring::graphite_threshold { 'restbase_html_storage_hit_latency':
-        description    => 'RESTBase HTML storage load mean latency',
+        description    => 'RESTBase HTML storage load mean latency ms',
         metric         => 
'movingMedian(restbase.sys_key-rev-value_-bucket-_-key--_revision--_tid-.GET.2xx.mean,
 15)',
         from           => '10min',
         warning        => '25', # 25ms

-- 
To view, visit https://gerrit.wikimedia.org/r/216892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id234d710e4bf8252dcc16551636314ea1c21cf91
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to