Catrope has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/216896

Change subject: Comment out API request initializing DM for now
......................................................................

Comment out API request initializing DM for now

Right now the Flow DM is unused in master, so there's no
benefit to populating it, but an API request on every
Flow board view is a significant cost.

Change-Id: I1a213346eeaa37c5a153cc4d93ec165a995773cb
---
M modules/flow-initialize.js
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/96/216896/1

diff --git a/modules/flow-initialize.js b/modules/flow-initialize.js
index ea47e00..7d2b6cc 100644
--- a/modules/flow-initialize.js
+++ b/modules/flow-initialize.js
@@ -29,7 +29,9 @@
                        renderedTopics: $( '.flow-topic' ).length,
                        boardId: $component.data( 'flow-id' )
                } );
-               mw.flow.system.populateBoardFromApi();
+               // FIXME don't wastefully initialize from the API while the DM 
is unused
+               // We should get initialization from JSON working before we 
start using the DM
+               //mw.flow.system.populateBoardFromApi();
 
                // HACK: We need to populate the old code when the
                // new is populated

-- 
To view, visit https://gerrit.wikimedia.org/r/216896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1a213346eeaa37c5a153cc4d93ec165a995773cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to