BryanDavis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/217524
Change subject: Fix non-numeric HTTP status code
......................................................................
Fix non-numeric HTTP status code
HTTP status codes should only be passed as numeric values.
Bug: T102028
Change-Id: Iecfb5c07e8c4357b66a799f5ff3c2d4a54f23a23
---
M includes/AjaxResponse.php
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/24/217524/1
diff --git a/includes/AjaxResponse.php b/includes/AjaxResponse.php
index b3a6573..d3fe214 100644
--- a/includes/AjaxResponse.php
+++ b/includes/AjaxResponse.php
@@ -86,7 +86,7 @@
$this->mDisabled = false;
$this->mText = '';
- $this->mResponseCode = '200 OK';
+ $this->mResponseCode = 200;
$this->mLastModified = false;
$this->mContentType = 'application/x-wiki';
@@ -158,8 +158,7 @@
*/
function sendHeaders() {
if ( $this->mResponseCode ) {
- $n = preg_replace( '/^ *(\d+)/', '\1',
$this->mResponseCode );
- HttpStatus::header( $n );
+ HttpStatus::header( $this->mResponseCode );
}
header ( "Content-Type: " . $this->mContentType );
--
To view, visit https://gerrit.wikimedia.org/r/217524
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecfb5c07e8c4357b66a799f5ff3c2d4a54f23a23
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
