Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218149
Change subject: OOUIHTMLForm: Correctly handle mSubmitModifierClass
......................................................................
OOUIHTMLForm: Correctly handle mSubmitModifierClass
That's what we get for hard-coding implementation details early on...
Bug: T98903
Change-Id: Icc20453c999c761b87e19a71ccd43d93b9c1bfa7
---
M includes/htmlform/OOUIHTMLForm.php
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/49/218149/1
diff --git a/includes/htmlform/OOUIHTMLForm.php
b/includes/htmlform/OOUIHTMLForm.php
index 6c9952a..4d5294c 100644
--- a/includes/htmlform/OOUIHTMLForm.php
+++ b/includes/htmlform/OOUIHTMLForm.php
@@ -68,15 +68,12 @@
$attribs += Linker::tooltipAndAccesskeyAttribs(
$this->mSubmitTooltip );
}
- $attribs['classes'] = array(
- 'mw-htmlform-submit',
- $this->mSubmitModifierClass,
- );
-
+ $attribs['classes'] = array( 'mw-htmlform-submit' );
$attribs['type'] = 'submit';
$attribs['label'] = $this->getSubmitText();
$attribs['value'] = $this->getSubmitText();
- $attribs['flags'] = array( 'primary', 'constructive' );
+ // That's what we get for hard-coding implementation
details early on...
+ $attribs['flags'] = array( 'primary', str_replace(
'mw-ui-', '', $this->mSubmitModifierClass ) );
$buttons .= new OOUI\ButtonInputWidget( $attribs );
}
--
To view, visit https://gerrit.wikimedia.org/r/218149
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc20453c999c761b87e19a71ccd43d93b9c1bfa7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
