jenkins-bot has submitted this change and it was merged. Change subject: Remove dup. initialization of LeadImagesHandler displayDensity ......................................................................
Remove dup. initialization of LeadImagesHandler displayDensity looks unnecessary to me to have it twice. Change-Id: I278cb934e8a105daf995c84fb45e106d6eb64596 --- M wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved Niedzielski: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java index f63c5b3..a898e8c 100755 --- a/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java +++ b/wikipedia/src/main/java/org/wikipedia/page/leadimages/LeadImagesHandler.java @@ -116,7 +116,6 @@ this.imageContainer = hidingView; this.bridge = bridge; this.webView = webview; - displayDensity = context.getResources().getDisplayMetrics().density; imagePlaceholder = (ImageView)imageContainer.findViewById(R.id.page_image_placeholder); image1 = (ImageViewWithFace)imageContainer.findViewById(R.id.page_image_1); -- To view, visit https://gerrit.wikimedia.org/r/218133 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I278cb934e8a105daf995c84fb45e106d6eb64596 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits