Paladox has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218322
Change subject: Fix phpcs warnings
......................................................................
Fix phpcs warnings
Change-Id: I2d7dbf7314257a3ad8f5f6b97a6949a2500d298f
---
M maintenance/convertExtensionToRegistration.php
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/22/218322/1
diff --git a/maintenance/convertExtensionToRegistration.php
b/maintenance/convertExtensionToRegistration.php
index 8adae2d..e9d4832 100644
--- a/maintenance/convertExtensionToRegistration.php
+++ b/maintenance/convertExtensionToRegistration.php
@@ -56,7 +56,8 @@
public function __construct() {
parent::__construct();
$this->mDescription = 'Converts extension entry points to the
new JSON registration format';
- $this->addArg( 'path', 'Location to the PHP entry point you
wish to convert', /* $required = */ true );
+ $this->addArg( 'path', 'Location to the PHP entry point you
wish to convert',
+ /* $required = */ true );
$this->addOption( 'skin', 'Whether to write to skin.json',
false, false );
}
@@ -95,7 +96,8 @@
}
if ( isset( $this->custom[$realName] ) ) {
- call_user_func_array( array( $this,
$this->custom[$realName] ), array( $realName, $value, $vars ) );
+ call_user_func_array( array( $this,
$this->custom[$realName] ),
+ array( $realName, $value, $vars ) );
} elseif ( in_array( $realName, $globalSettings ) ) {
$this->json[$realName] = $value;
} elseif ( array_key_exists( $realName,
$this->noLongerSupportedGlobals ) ) {
@@ -133,7 +135,8 @@
protected function handleExtensionFunctions( $realName, $value ) {
foreach ( $value as $func ) {
if ( $func instanceof Closure ) {
- $this->error( "Error: Closures cannot be
converted to JSON. Please move your extension function somewhere else.", 1 );
+ $this->error( "Error: Closures cannot be
converted to JSON.
+ Please move your extension function somewhere
else.", 1 );
}
}
@@ -197,7 +200,8 @@
foreach ( $value as $hookName => $handlers ) {
foreach ( $handlers as $func ) {
if ( $func instanceof Closure ) {
- $this->error( "Error: Closures cannot
be converted to JSON. Please move the handler for $hookName somewhere else.", 1
);
+ $this->error( "Error: Closures cannot
be converted to JSON.
+ Please move the handler for $hookName
somewhere else.", 1 );
}
}
}
@@ -228,7 +232,6 @@
}
}
}
-
$this->json[$realName][$name] = $data;
}
--
To view, visit https://gerrit.wikimedia.org/r/218322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d7dbf7314257a3ad8f5f6b97a6949a2500d298f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
