Dominic.sauer has submitted this change and it was merged.
Change subject: Implemented further hints from review from Daniel
......................................................................
Implemented further hints from review from Daniel
Change-Id: I45f0665e816c7f05e87c826abfe4360253b04b43
---
M WikibaseQualityConstraints.php
M includes/Violations/CheckResultToViolationTranslator.php
M includes/Violations/ConstraintViolationFormatter.php
M specials/SpecialConstraintReport.php
4 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Dominic.sauer: Verified; Looks good to me, approved
diff --git a/WikibaseQualityConstraints.php b/WikibaseQualityConstraints.php
index a35b774..bb46986 100644
--- a/WikibaseQualityConstraints.php
+++ b/WikibaseQualityConstraints.php
@@ -7,12 +7,12 @@
call_user_func( function() {
// Set credits
$GLOBALS['wgExtensionCredits']['specialpage'][] = array(
- 'path' => __FILE__,
+ 'path' => __DIR__,
'name' => 'WikibaseQualityConstraints',
'author' => 'BP2014N1',
'url' =>
'https://www.mediawiki.org/wiki/Extension:WikibaseQualityConstraints',
'descriptionmsg' => 'wbqc-desc',
- 'version' => '1.0.0'
+ 'version' => '0.1.0'
);
// Initialize localization and aliases
diff --git a/includes/Violations/CheckResultToViolationTranslator.php
b/includes/Violations/CheckResultToViolationTranslator.php
index 2e6168a..a9397b8 100644
--- a/includes/Violations/CheckResultToViolationTranslator.php
+++ b/includes/Violations/CheckResultToViolationTranslator.php
@@ -7,7 +7,7 @@
use Wikibase\Lib\Store\EntityRevisionLookup;
use WikibaseQuality\ConstraintReport\ConstraintCheck\Result\CheckResult;
use WikibaseQuality\Violations\Violation;
-use Doctrine\Instantiator\Exception\InvalidArgumentException;
+use InvalidArgumentException;
class CheckResultToViolationTranslator {
diff --git a/includes/Violations/ConstraintViolationFormatter.php
b/includes/Violations/ConstraintViolationFormatter.php
index bf79bc3..a9319e8 100755
--- a/includes/Violations/ConstraintViolationFormatter.php
+++ b/includes/Violations/ConstraintViolationFormatter.php
@@ -4,7 +4,7 @@
use UnexpectedValueException;
use Html;
-use Doctrine\Instantiator\Exception\InvalidArgumentException;
+use InvalidArgumentException;
use WikibaseQuality\Violations\Violation;
use WikibaseQuality\Violations\ViolationFormatter;
diff --git a/specials/SpecialConstraintReport.php
b/specials/SpecialConstraintReport.php
index 3c99ad8..15f7c1c 100644
--- a/specials/SpecialConstraintReport.php
+++ b/specials/SpecialConstraintReport.php
@@ -20,8 +20,8 @@
use DataValues;
use DataValues\DataValue;
use Html;
-use Doctrine\Instantiator\Exception\InvalidArgumentException;
-use Doctrine\Instantiator\Exception\UnexpectedValueException;
+use InvalidArgumentException;
+use UnexpectedValueException;
use Wikibase\DataModel\Entity\Entity;
use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\EntityIdParsingException;
@@ -698,7 +698,7 @@
private function saveResultsInViolationsTable( $entity, $results ) {
$violations =
$this->checkResultToViolationTranslator->translateToViolation( $entity,
$results );
foreach( $violations as $violation ) {
- $this->violationStore->save( $violation );
+ $this->violationStore->insert( $violation );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/218320
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I45f0665e816c7f05e87c826abfe4360253b04b43
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikidataQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Soeren.oldag <[email protected]>
Gerrit-Reviewer: Dominic.sauer <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
