jenkins-bot has submitted this change and it was merged.
Change subject: Never apply border-box to 'body' (i.e. for a 'Skin')
......................................................................
Never apply border-box to 'body' (i.e. for a 'Skin')
Ideally this check would've been !( this instanceof Skin ) but
in some case Skin hasn't registered yet with the module loader.
Bug: T86366
Change-Id: Ic49206ec463b72b7c0285a84849ac0f5e08dbdf6
---
M resources/mobile.view/View.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, but someone else must approve
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.view/View.js b/resources/mobile.view/View.js
index 4529a2c..eeeed8e 100644
--- a/resources/mobile.view/View.js
+++ b/resources/mobile.view/View.js
@@ -196,7 +196,7 @@
*/
_postInitialize: function () {
this.$el.addClass( this.className );
- if ( this.isBorderBox ) {
+ if ( this.isBorderBox && !this.$el.is( 'body' ) ) {
// FIXME: Merge with className property (?)
this.$el.addClass( 'view-border-box' );
}
--
To view, visit https://gerrit.wikimedia.org/r/218608
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic49206ec463b72b7c0285a84849ac0f5e08dbdf6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
