JanZerebecki has submitted this change and it was merged.
Change subject: Upgrade data-model to be compatible to Wikibase.
......................................................................
Upgrade data-model to be compatible to Wikibase.
Change-Id: If9ae486ee889770c4fa2350085778df4eb61e453
---
M composer.json
M tests/phpunit/Specials/SpecialViolationsPageTest.php
2 files changed, 7 insertions(+), 9 deletions(-)
Approvals:
JanZerebecki: Verified; Looks good to me, approved
diff --git a/composer.json b/composer.json
index 2afaec7..2ad1b47 100755
--- a/composer.json
+++ b/composer.json
@@ -15,7 +15,7 @@
},
"require": {
"php": ">=5.3.0",
- "wikibase/data-model": "~2.6",
+ "wikibase/data-model": "~3.0",
"serialization/serialization": "3.*,>=3.2.1"
},
"require-dev": {
diff --git a/tests/phpunit/Specials/SpecialViolationsPageTest.php
b/tests/phpunit/Specials/SpecialViolationsPageTest.php
index 240dd52..641014f 100644
--- a/tests/phpunit/Specials/SpecialViolationsPageTest.php
+++ b/tests/phpunit/Specials/SpecialViolationsPageTest.php
@@ -83,23 +83,21 @@
$dataValue = new StringValue( 'foo' );
$snak = new PropertyValueSnak( self::$idMap['P1'],
$dataValue );
- $claim = new Claim( $snak );
$claimGuid = sprintf(
'%s%scc9cf0b2-ff64-451c-8e4a-2f0b38f6e7ce', self::$idMap['Q1'],
ClaimGuid::SEPARATOR );
self::$claimGuids['P1'] = $claimGuid;
- $claim->setGuid( $claimGuid );
- $statement = new Statement( $claim );
- $itemQ1->addClaim( $statement );
+ $statement = new Statement( $snak );
+ $statement->setGuid( $claimGuid );
+ $itemQ1->getStatements()->addStatement( $statement );
$store->saveEntity( $itemQ1, 'TestEntityQ1',
$GLOBALS['wgUser'], EDIT_UPDATE );
$dataValue = new StringValue( 'foo' );
$snak = new PropertyValueSnak( self::$idMap['P2'],
$dataValue );
- $claim = new Claim( $snak );
$claimGuid = sprintf(
'%s%sbe55b140-7fb5-40e0-87ee-826fd452687d', self::$idMap['Q2'],
ClaimGuid::SEPARATOR );
self::$claimGuids['P2'] = $claimGuid;
- $claim->setGuid( $claimGuid );
- $statement = new Statement( $claim );
- $itemQ2->addClaim( $statement );
+ $statement = new Statement( $snak );
+ $statement->setGuid( $claimGuid );
+ $itemQ2->getStatements()->addStatement( $statement );
$store->saveEntity( $itemQ2, 'TestEntityQ2',
$GLOBALS['wgUser'], EDIT_UPDATE );
--
To view, visit https://gerrit.wikimedia.org/r/218650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9ae486ee889770c4fa2350085778df4eb61e453
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikidataQuality
Gerrit-Branch: master
Gerrit-Owner: JanZerebecki <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
