Giuseppe Lavagetto has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218883
Change subject: confctl: fix tags handling
......................................................................
confctl: fix tags handling
* service.py: Added the tags
* tool.py: Made the error message a bit clearer
Change-Id: I8cd9feeef391e52e0973f0d556332b6b3d625692
---
M conftool/cli/tool.py
M conftool/service.py
2 files changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/software/conftool
refs/changes/83/218883/1
diff --git a/conftool/cli/tool.py b/conftool/cli/tool.py
index 60d3d33..0826f59 100644
--- a/conftool/cli/tool.py
+++ b/conftool/cli/tool.py
@@ -53,7 +53,7 @@
try:
tags = cls.get_tags(args.tags.split(','))
except KeyError as e:
- _log.critical("Invalid tag list %s - reason: %s", args.tags, e)
+ _log.critical("Invalid tag list %s - we're missing tag: %s",
args.tags, e)
sys.exit(1)
for unit in args.action:
diff --git a/conftool/service.py b/conftool/service.py
index be8761e..a5ff77b 100644
--- a/conftool/service.py
+++ b/conftool/service.py
@@ -4,6 +4,7 @@
class Service(KVObject):
_schema = {'default_values': dict, 'datacenters': list}
+ _tags = ['cluster']
def __init__(self, cluster, name, **kwdargs):
self._key = os.path.join(self.config.services_path, cluster, name)
--
To view, visit https://gerrit.wikimedia.org/r/218883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cd9feeef391e52e0973f0d556332b6b3d625692
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/conftool
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
