Matthias Mullie has submitted this change and it was merged.
Change subject: Don't rely on __toString
......................................................................
Don't rely on __toString
UUID's __toString warns when it's called & this was one that I had
apparently missed.
Change-Id: Ib3a43c43d7b07e00ff892710fa4288c57cc486fe
---
M includes/Formatter/AbstractQuery.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sbisson: Looks good to me, approved
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Formatter/AbstractQuery.php
b/includes/Formatter/AbstractQuery.php
index a0df73b..50669d7 100644
--- a/includes/Formatter/AbstractQuery.php
+++ b/includes/Formatter/AbstractQuery.php
@@ -333,7 +333,7 @@
throw new \MWException( 'Did not locate root post ' .
$rootPostId->getAlphadecimal() );
}
if ( !$rootPost->isTopicTitle() ) {
- throw new \MWException( "Not a topic title: " .
$rootPost->getRevisionId() );
+ throw new \MWException( "Not a topic title: " .
$rootPost->getRevisionId()->getAlphadecimal() );
}
return $rootPost;
--
To view, visit https://gerrit.wikimedia.org/r/218686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3a43c43d7b07e00ff892710fa4288c57cc486fe
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
