jenkins-bot has submitted this change and it was merged. Change subject: Rename getRedirectCreator > newRedirectCreationInteractor ......................................................................
Rename getRedirectCreator > newRedirectCreationInteractor Less confusing when searching for such a method in the factory. This also means the new method I am about to introduce will be named the same Change-Id: Iaca4febe9db04e6032701d05cd6228b23b1faf0b --- M repo/includes/WikibaseRepo.php M repo/includes/specials/SpecialRedirectEntity.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Thiemo Mättig (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/WikibaseRepo.php b/repo/includes/WikibaseRepo.php index f71e551..b9bbfa9 100644 --- a/repo/includes/WikibaseRepo.php +++ b/repo/includes/WikibaseRepo.php @@ -311,7 +311,7 @@ return $this->getStore()->getEntityRevisionLookup( $uncached ); } - public function getRedirectCreator( User $user, IContextSource $context ) { + public function newRedirectCreationInteractor( User $user, IContextSource $context ) { return new RedirectCreationInteractor( $this->getEntityRevisionLookup( 'uncached' ), $this->getEntityStore(), diff --git a/repo/includes/specials/SpecialRedirectEntity.php b/repo/includes/specials/SpecialRedirectEntity.php index 01910ac..f74e66e 100644 --- a/repo/includes/specials/SpecialRedirectEntity.php +++ b/repo/includes/specials/SpecialRedirectEntity.php @@ -57,7 +57,7 @@ new TokenCheckInteractor( $this->getUser() ), - $wikibaseRepo->getRedirectCreator( + $wikibaseRepo->newRedirectCreationInteractor( $this->getUser(), $this->getContext() ) -- To view, visit https://gerrit.wikimedia.org/r/218847 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaca4febe9db04e6032701d05cd6228b23b1faf0b Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits