Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219170
Change subject: Fix test for unknown sites in OtherProjectsSitesGeneratorTest
......................................................................
Fix test for unknown sites in OtherProjectsSitesGeneratorTest
Change-Id: I893b08f4441666abb7b4a6bc1d6d085eafaabf72
---
M client/tests/phpunit/includes/OtherProjectsSitesGeneratorTest.php
1 file changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/70/219170/1
diff --git a/client/tests/phpunit/includes/OtherProjectsSitesGeneratorTest.php
b/client/tests/phpunit/includes/OtherProjectsSitesGeneratorTest.php
index 0012d29..2eb632f 100644
--- a/client/tests/phpunit/includes/OtherProjectsSitesGeneratorTest.php
+++ b/client/tests/phpunit/includes/OtherProjectsSitesGeneratorTest.php
@@ -75,15 +75,22 @@
array()
);
- $tests['Unknown site'] = array(
- array( 'wikipedia', 'wikisource' ),
- 'kittenswiki',
- array()
- );
-
return $tests;
}
+ public function testOtherProjectSiteIds_unknownSite() {
+ $siteStore = $this->getSiteStoreMock();
+ $otherProjectsSitesProvider = new OtherProjectsSitesGenerator(
$siteStore, 'kittenswiki', array( 'wikidata' ) );
+
+ // getOtherProjectsSiteIds does wfWarn in case it's being
called with a siteid
+ // it doesn't know about. That's fine, we can just ignore that.
+ \MediaWiki\suppressWarnings();
+ $result = $otherProjectsSitesProvider->getOtherProjectsSiteIds(
array( 'wikipedia', 'wikisource' ) );
+ \MediaWiki\restoreWarnings();
+
+ $this->assertSame( array(), $result );
+ }
+
/**
* @return MockSiteStore
*/
--
To view, visit https://gerrit.wikimedia.org/r/219170
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I893b08f4441666abb7b4a6bc1d6d085eafaabf72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
