Soeren.oldag has uploaded a new change for review.
https://gerrit.wikimedia.org/r/219243
Change subject: Implemented further hints from review from Daniel.
......................................................................
Implemented further hints from review from Daniel.
Change-Id: I6e3ebe30061fa8cce849c9f7b6a2d8daf510b02e
Conflicts:
includes/CrossCheck/CrossChecker.php
specials/SpecialCrossCheck.php
tests/phpunit/Specials/SpecialCrossCheckTest.php (+1 squashed commit)
Squashed commits:
[6437ec0] Implemented further hints from review from Daniel. (Cherry Pick)
Change-Id: I16d712949101aaa6ff7a770466317aa4ef0157d5
---
M WikibaseQualityExternalValidation.php
M WikibaseQualityExternalValidationHooks.php
R api/RunCrossCheck.php
M composer.json
M i18n/en.json
M i18n/qqq.json
D includes/ApiModuleFactory.php
A includes/CrossCheck/ComparativeValueParser/BasicComparativeValueParser.php
A
includes/CrossCheck/ComparativeValueParser/ComparativeGlobeCoordinateParser.php
A
includes/CrossCheck/ComparativeValueParser/ComparativeMonolingualTextParser.php
A
includes/CrossCheck/ComparativeValueParser/ComparativeMultilingualTextValueParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeQuantityParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeStringParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeStringValueParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeTimeParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeValueParser.php
A includes/CrossCheck/ComparativeValueParser/ComparativeValueParserFactory.php
A
includes/CrossCheck/ComparativeValueParser/DispatchingComparativeValueParser.php
M includes/CrossCheck/Comparer/DataValueComparer.php
D includes/CrossCheck/Comparer/DataValueComparerBase.php
M includes/CrossCheck/Comparer/DataValueComparerFactory.php
M includes/CrossCheck/Comparer/DispatchingDataValueComparer.php
M includes/CrossCheck/Comparer/EntityIdValueComparer.php
M includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php
M includes/CrossCheck/Comparer/MonolingualTextValueComparer.php
M includes/CrossCheck/Comparer/MultilingualTextValueComparer.php
M includes/CrossCheck/Comparer/QuantityValueComparer.php
M includes/CrossCheck/Comparer/StringComparer.php
M includes/CrossCheck/Comparer/StringValueComparer.php
M includes/CrossCheck/Comparer/TimeValueComparer.php
M includes/CrossCheck/CrossCheckInteractor.php
M includes/CrossCheck/CrossChecker.php
R includes/CrossCheck/ReferenceChecker.php
R includes/CrossCheck/Result/ComparisonResult.php
M includes/CrossCheck/Result/CrossCheckResult.php
M includes/CrossCheck/Result/CrossCheckResultList.php
M includes/CrossCheck/Result/ReferenceResult.php
M includes/DumpMetaInformation/DumpMetaInformation.php
A includes/DumpMetaInformation/DumpMetaInformationLookup.php
D includes/DumpMetaInformation/DumpMetaInformationRepo.php
A includes/DumpMetaInformation/DumpMetaInformationStore.php
A includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php
M includes/EvaluateCrossCheckJob.php
M includes/EvaluateCrossCheckJobService.php
M includes/ExternalDataRepo.php
D includes/ExternalValidationFactory.php
A includes/ExternalValidationServices.php
R includes/Serializer/ComparisonResultSerializer.php
M includes/Serializer/CrossCheckResultSerializer.php
M includes/Serializer/DumpMetaInformationSerializer.php
M includes/Serializer/SerializerFactory.php
D includes/SpecialPageFactory.php
A includes/UpdateTable/ExternalDataImporter.php
D includes/UpdateTable/Importer.php
R includes/UpdateTable/TarImportSettings.php
M maintenance/UpdateTable.php
M specials/SpecialCrossCheck.php
M specials/SpecialExternalDbs.php
M sql/create_wbqev_dump_information.sql
R tests/phpunit/Api/RunCrossCheckTest.php
D tests/phpunit/ApiModuleFactoryTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/BasicComparativeValueParserTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeMultilingualTextValueParserTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeStringValueParserTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeValueParserBaseTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeValueParserFactoryTest.php
A
tests/phpunit/CrossCheck/ComparativeValueParser/DispatchingComparativeValueParserTest.php
M tests/phpunit/CrossCheck/Comparer/DataValueComparerBaseTest.php
M tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php
M tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/StringComparerTest.php
M tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php
M tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php
D tests/phpunit/CrossCheck/Comparer/testdata/Q1.json
M tests/phpunit/CrossCheck/CrossCheckerTest.php
R tests/phpunit/CrossCheck/ReferenceCheckerTest.php
R tests/phpunit/CrossCheck/Result/ComparisonResultTest.php
M tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php
M tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php
A tests/phpunit/CrossCheck/testdata/P227.json
A tests/phpunit/CrossCheck/testdata/P228.json
D tests/phpunit/DumpMetaInformation/DumpMetaInformationRepoTest.php
M tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php
A tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php
M tests/phpunit/EvaluateCrossCheckJobServiceTest.php
M tests/phpunit/ExternalDataRepoTest.php
D tests/phpunit/ExternalValidationFactoryTest.php
A tests/phpunit/ExternalValidationServicesTest.php
R tests/phpunit/Serializer/ComparisonResultSerializerTest.php
M tests/phpunit/Serializer/CrossCheckResultSerializerTest.php
M tests/phpunit/Serializer/DumpMetaInformationSerializerTest.php
M tests/phpunit/Serializer/SerializerFactoryTest.php
D tests/phpunit/SpecialPageFactoryTest.php
M tests/phpunit/Specials/SpecialCrossCheckTest.php
M tests/phpunit/Specials/SpecialExternalDbsTest.php
R tests/phpunit/UpdateTable/TarTarImportSettingsTest.php
M tests/phpunit/UpdateTable/UpdateTableTest.php
102 files changed, 4,839 insertions(+), 4,150 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityExternalValidation
refs/changes/43/219243/1
--
To view, visit https://gerrit.wikimedia.org/r/219243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16d712949101aaa6ff7a770466317aa4ef0157d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityExternalValidation
Gerrit-Branch: v1
Gerrit-Owner: Soeren.oldag <soeren_ol...@freenet.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
