Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/219301

Change subject: build: Remove 'clean' task
......................................................................

build: Remove 'clean' task

Was only used for 'docs/js'. This was primarily to prevent leaving
behind generated files from previous runs. However JSDuck takes
care of that already.

This is in preparation for making MobileFrontend ride the
npm-run-doc train in Jenkins.

Change-Id: Icf3c8571f094f779abb80ad3b44438dc84b2dd68
---
M Gruntfile.js
M package.json
2 files changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/01/219301/1

diff --git a/Gruntfile.js b/Gruntfile.js
index 31de7bf..a9f2c45 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -14,7 +14,6 @@
        grunt.loadNpmTasks( 'grunt-notify' );
        grunt.loadNpmTasks( 'grunt-svg2png' );
        grunt.loadNpmTasks( 'grunt-jsduck' );
-       grunt.loadNpmTasks( 'grunt-contrib-clean' );
 
        grunt.initConfig( {
                URL: process.env.MEDIAWIKI_URL || 
'http://127.0.0.1:8080/w/index.php/',
@@ -108,9 +107,6 @@
                                }
                        }
                },
-               clean: {
-                       jsdocs: [ 'docs/js' ]
-               },
                jsduck: {
                        main: {
                                src: [
@@ -148,7 +144,7 @@
        } );
 
        grunt.registerTask( 'lint', [ 'jshint', 'jscs' ] );
-       grunt.registerTask( 'docs', [ 'clean:jsdocs', 'mkdir:jsdocs', 
'jsduck:main' ] );
+       grunt.registerTask( 'docs', [ 'mkdir:jsdocs', 'jsduck:main' ] );
 
        // grunt test will be run by npm test which will be run by Jenkins
        // Do not execute qunit here, or other tasks that require full mediawiki
diff --git a/package.json b/package.json
index 2c05655..42b407e 100644
--- a/package.json
+++ b/package.json
@@ -20,8 +20,6 @@
        },
        "devDependencies": {
                "grunt-mkdir": "^0.1.2",
-               "grunt-contrib-clean": "^0.6.0",
-               "grunt-mkdir": "^0.1.2",
                "grunt-svg2png": "0.2.5",
                "grunt-contrib-jshint": "0.10.0",
                "grunt-jscs": "1.8.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/219301
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf3c8571f094f779abb80ad3b44438dc84b2dd68
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to