Catrope has submitted this change and it was merged. Change subject: (bug 42552) Link inspector close on selection change ......................................................................
(bug 42552) Link inspector close on selection change The logic in ve.ui.LinkInspector.onUpdate was very flawed. This patch makes it so: * When something happens, if there's an inspector open then so long as the selection hasn't changed the inspector is updated (such as the window being resized) * If the selection does change, the inspector is closed * If there's no inspector open, we try to show a menu of available inspectors Change-Id: I859123a5fcd36bc2afb2e578f81f30a944c8583a --- M modules/ve/ui/ve.ui.Context.js 1 file changed, 11 insertions(+), 10 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/36088 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I859123a5fcd36bc2afb2e578f81f30a944c8583a Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: Trevor Parscal <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
