Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220141
Change subject: Fix minor bug in referenceview.js
......................................................................
Fix minor bug in referenceview.js
This patch contains some very minor bug fixes and code style fixes
that I split from I9444ae5.
Bug: T87759
Change-Id: Ibd975a6cef439edba1774bfbd72ecb45b0a34910
---
M view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
M view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js
M view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js
3 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/41/220141/1
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
index f0e540a..1a9ee33 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
@@ -148,7 +148,7 @@
var $snaklistview = $( event.target ).closest(
':wikibase-snaklistview' ),
snaklistview = $snaklistview.data(
'snaklistview' );
- if( snaklistview && !snaklistview.value() ) {
+ if( snaklistview &&
!snaklistview.value().length ) {
self.$listview.data( 'listview'
).removeItem( snaklistview.element );
}
}
@@ -208,7 +208,11 @@
*/
value: function( reference ) {
if( reference ) {
- this.option( 'value', reference );
+ return this.option( 'value', reference );
+ }
+
+ if( !this.$listview ) {
+ return null;
}
var snakList = new wb.datamodel.SnakList();
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js
index 7474e77..0f394d1 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.snaklistview.js
@@ -319,7 +319,7 @@
* committed).
*
* @param {wikibase.datamodel.SnakList} [snakList]
- * @return {wikibase.datamodel.SnakList|null|undefined}
+ * @return {wikibase.datamodel.SnakList|undefined}
*/
value: function( snakList ) {
if( snakList !== undefined ) {
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js
index bf9aefd..60e7330 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementlistview.js
@@ -189,10 +189,10 @@
property: !!(
value || propertyId )
}
},
- dataTypeStore: self.option(
'dataTypeStore' ),
- entityStore: self.option(
'entityStore' ),
- valueViewBuilder: self.option(
'valueViewBuilder' ),
- entityChangersFactory:
self.option( 'entityChangersFactory' ),
+ dataTypeStore:
self.options.dataTypeStore,
+ entityStore:
self.options.entityStore,
+ valueViewBuilder:
self.options.valueViewBuilder,
+ entityChangersFactory:
self.options.entityChangersFactory,
claimsChanger:
self._claimsChanger,
guidGenerator:
self.options.claimGuidGenerator
};
--
To view, visit https://gerrit.wikimedia.org/r/220141
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd975a6cef439edba1774bfbd72ecb45b0a34910
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
