Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220476
Change subject: Don't specify period when calling cronolog.
......................................................................
Don't specify period when calling cronolog.
On labcontrol1001 (== Trusty) specifying the period results in
/usr/bin/cronolog: invalid explicit period specification ((null))
Causing Apache to not work at all.
Lots of people report this issue online; it seems to be specific to the
Apache version somehow. Of course the cronolog man page doesn't say
what the --period argument is for, other than saying that it changes
the period.
Removing the specification gets apache working again, although error.log
is now spammed with things like:
App 13148 stdout:
App 13155 stdout:
App 13180 stdout:
App 13187 stdout:
Still, I call it an improvement.
Change-Id: I1f39c91b7b97bf40f67c89e4c4b449f1b13dd1e5
---
M modules/jmxtrans
M modules/puppetmaster/templates/puppetmaster.erb
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/76/220476/1
diff --git a/modules/jmxtrans b/modules/jmxtrans
index 3d9d8f8..690aac5 160000
--- a/modules/jmxtrans
+++ b/modules/jmxtrans
-Subproject commit 3d9d8f8f5c20c36f4f257811ac733aabe3f12a81
+Subproject commit 690aac54ea2e8e39f1a4c52c1a97005b1867cea3
diff --git a/modules/puppetmaster/templates/puppetmaster.erb
b/modules/puppetmaster/templates/puppetmaster.erb
index 65c1113..ae99a6c 100644
--- a/modules/puppetmaster/templates/puppetmaster.erb
+++ b/modules/puppetmaster/templates/puppetmaster.erb
@@ -97,7 +97,7 @@
<%- end -%>
LogFormat "%h %l %u %{%Y-%m-%d %H:%M:%S}t \"%r\" %>s %O %D \"%{Referer}i\"
\"%{User-Agent}i\"" puppetmaster
- CustomLog "|/usr/bin/cronolog --once-only --period=\"1 minute\"
/var/log/apache2/puppetmaster.log" puppetmaster
+ CustomLog "|/usr/bin/cronolog --once-only
/var/log/apache2/puppetmaster.log" puppetmaster
</VirtualHost>
<%- end -%>
@@ -132,6 +132,6 @@
</Directory>
LogFormat "%h %l %u %{%Y-%m-%d %H:%M:%S}t \"%r\" %>s %O %D \"%{Referer}i\"
\"%{User-Agent}i\"" puppetmaster
- CustomLog "|/usr/bin/cronolog --once-only --period=\"1 minute\"
/var/log/apache2/puppetmaster-backend.log" puppetmaster
+ CustomLog "|/usr/bin/cronolog --once-only
/var/log/apache2/puppetmaster-backend.log" puppetmaster
</VirtualHost>
<%- end -%>
--
To view, visit https://gerrit.wikimedia.org/r/220476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f39c91b7b97bf40f67c89e4c4b449f1b13dd1e5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
