Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220551
Change subject: Use FOR UPDATE when selecting ids in SqlIdGenerator
......................................................................
Use FOR UPDATE when selecting ids in SqlIdGenerator
Seems we have collisions there, if a lot of items
are being created simultaneously.
Change-Id: Ifb5874e245f35f5239e1072f84e4d889f6614f75
---
M repo/includes/store/sql/SqlIdGenerator.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/51/220551/1
diff --git a/repo/includes/store/sql/SqlIdGenerator.php
b/repo/includes/store/sql/SqlIdGenerator.php
index 6b33d4c..5e7cbfc 100644
--- a/repo/includes/store/sql/SqlIdGenerator.php
+++ b/repo/includes/store/sql/SqlIdGenerator.php
@@ -73,7 +73,9 @@
$currentId = $database->selectRow(
'wb_id_counters',
'id_value',
- array( 'id_type' => $type )
+ array( 'id_type' => $type ),
+ __METHOD__,
+ array( 'FOR UPDATE' )
);
if ( is_object( $currentId ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/220551
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb5874e245f35f5239e1072f84e4d889f6614f75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
