GWicke has submitted this change and it was merged.
Change subject: Be smarter about when to migrate start meta-tag (not always!)
......................................................................
Be smarter about when to migrate start meta-tag (not always!)
* Commit 942ea55 always migrated a start meta-tag if it was
the last child of a node. However, this is incorrect if
the end-tag width of the parent node is non-zero, for
example tables. Migrating the meta-tag across the
parent's end-tag barrier is invalid since the end-tag is
now no longer known to be generated by the template. Fixed
this error by testing end-tag width of the parent node.
* Similarly, blindly ignoring a single newline while moving
the start-meta tag is not the right thing (c6e2b3c0). It
may be correct in certain scenarios (when the parent is a
certain kind of node), but not always. Pending investigation,
turning this off.
* These fixes now eliminate regressions on wikitext of this form:
----
{{s-start}}
{{s-end}}
----
* No change in parser tests (figure out a way to add the above
example as a parser test).
* Eliminates regressions on en:CR10, en:Nottm Forest, and
possibly others.
* Unrelated change in this commit: Added a comment to explain
a change in commit 12e2116.
Change-Id: Ifef2c0617d13b72276bec3ab0e9fb949471720e4
---
M js/lib/ext.core.PreHandler.js
M js/lib/mediawiki.DOMPostProcessor.js
2 files changed, 51 insertions(+), 31 deletions(-)
Approvals:
GWicke: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/36328
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifef2c0617d13b72276bec3ab0e9fb949471720e4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
