jenkins-bot has submitted this change and it was merged.
Change subject: Remove unused return values
......................................................................
Remove unused return values
There is no return value specified in the documentation, the push action
returns void, which makes the return values inconsistent in any case. I
checked callers, and none appear to do anything with the return value of
this method.
Change-Id: I660a5673037fd39b5c34633ee96daa5e1b70fe7c
---
M utils/MessageIndexRebuildJob.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/utils/MessageIndexRebuildJob.php b/utils/MessageIndexRebuildJob.php
index 413df98..cfa7da5 100644
--- a/utils/MessageIndexRebuildJob.php
+++ b/utils/MessageIndexRebuildJob.php
@@ -43,11 +43,9 @@
public function insert() {
global $wgTranslateDelayedMessageIndexRebuild;
if ( $wgTranslateDelayedMessageIndexRebuild ) {
- return JobQueueGroup::singleton()->push( $this );
+ JobQueueGroup::singleton()->push( $this );
} else {
$this->run();
-
- return true;
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/213996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I660a5673037fd39b5c34633ee96daa5e1b70fe7c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
