Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/220945
Change subject: Make WikibaseClientTest::testGetLangLinkHandlerReturnType more
robust
......................................................................
Make WikibaseClientTest::testGetLangLinkHandlerReturnType more robust
Bug: T102854
Change-Id: I0e616d7b5fc31af41bc6ff1721397d7e2e70563d
(cherry picked from commit 3c75d367fa523a1608491f9b2a515c650bf01ce5)
---
M client/tests/phpunit/includes/WikibaseClientTest.php
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/45/220945/1
diff --git a/client/tests/phpunit/includes/WikibaseClientTest.php
b/client/tests/phpunit/includes/WikibaseClientTest.php
index a54f5a8..5ce07be 100644
--- a/client/tests/phpunit/includes/WikibaseClientTest.php
+++ b/client/tests/phpunit/includes/WikibaseClientTest.php
@@ -76,7 +76,15 @@
}
public function testGetLangLinkHandlerReturnType() {
- $returnValue = $this->getWikibaseClient()->getLangLinkHandler();
+ $settings = clone
WikibaseClient::getDefaultInstance()->getSettings();
+
+ $settings->setSetting( 'siteGroup', 'wikipedia' );
+ $settings->setSetting( 'siteGlobalID', 'enwiki' );
+ $settings->setSetting( 'languageLinkSiteGroup', 'wikipedia' );
+
+ $wikibaseClient = new WikibaseClient( $settings,
Language::factory( 'en' ), $this->getSiteStore() );
+
+ $returnValue = $wikibaseClient->getLangLinkHandler();
$this->assertInstanceOf( 'Wikibase\LangLinkHandler',
$returnValue );
}
--
To view, visit https://gerrit.wikimedia.org/r/220945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e616d7b5fc31af41bc6ff1721397d7e2e70563d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.26wmf9
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
