Spage has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/221081

Change subject: Use actual booleans in API request
......................................................................

Use actual booleans in API request

Popups' API query request specifies the string 'true' as the value for
some boolean request parameters, but that's functionally identical to
specifying boolean true -- both get encoded as param=true in the HTTP
request.

Change-Id: Icc5f4b8ef6faaffe4a23c964f8cd8c2582d28381
---
M resources/ext.popups.renderer.article.js
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups 
refs/changes/81/221081/1

diff --git a/resources/ext.popups.renderer.article.js 
b/resources/ext.popups.renderer.article.js
index 2c6ec55..e29fba8 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -50,12 +50,12 @@
                mw.popups.render.currentRequest = mw.popups.api.get( {
                        action: 'query',
                        prop: 'extracts|pageimages|revisions|info',
-                       redirects: 'true',
-                       exintro: 'true',
+                       redirects: true,
+                       exintro: true,
                        exsentences: 2,
                        // there is an added geometric limit on 
.mwe-popups-extract
                        // so that text does not overflow from the card
-                       explaintext: 'true',
+                       explaintext: true,
                        piprop: 'thumbnail',
                        pithumbsize: 300,
                        rvprop: 'timestamp',

-- 
To view, visit https://gerrit.wikimedia.org/r/221081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc5f4b8ef6faaffe4a23c964f8cd8c2582d28381
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to