GWicke has submitted this change and it was merged.
Change subject: Use dataAttribs for NlTks so tsr gets cleared from template
NlTks.
......................................................................
Use dataAttribs for NlTks so tsr gets cleared from template NlTks.
* Commit 12e2116 added tsr on nl-tks and set tsr on pre-tokens.
However, it didn't take care of clear tsr for nl-tokens from
newlines which meant that pres from templates got tsr set.
This in turn corrupted dsr computation downstream and caused
a lot of regressions in roundtrip tests.
* This patch fixes it by using dataAttribs object for NlTk as
well so tsr gets cleared automatically.
* Updated DSR computation to mark a pre-node's tsr to be limited
tsr applicable only to the start node, not the entire dom.
* This fixes regressions on the followingtest snippet independent
of the (nondeterministic) variability of the token stream (caused
by an independent, possibly async, bug). It always RTs back
correctly no matter what the parsed DOM is.
----
{{Nihongo|True Assassin|foo|Shin Asashin}}
{{Nihongo|Delusional Heartbeat|bar|Zabaniya}}
----
Change-Id: I231142f3f876f70e5ff079335fb58608369218c4
---
M js/lib/ext.core.PreHandler.js
M js/lib/mediawiki.DOMPostProcessor.js
M js/lib/mediawiki.parser.defines.js
3 files changed, 16 insertions(+), 10 deletions(-)
Approvals:
GWicke: Verified; Looks good to me, approved
--
To view, visit https://gerrit.wikimedia.org/r/36392
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I231142f3f876f70e5ff079335fb58608369218c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
