Jonaskeutel has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222080
Change subject: fix parameter bug in diffWithinRangeChecker
......................................................................
fix parameter bug in diffWithinRangeChecker
Change-Id: If3c6a96670f7c4004e427af63441dfe4f387121c
---
M includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/80/222080/1
diff --git a/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
b/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
index ec5f1cd..7ff899f 100755
--- a/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
+++ b/includes/ConstraintCheck/Checker/DiffWithinRangeChecker.php
@@ -82,8 +82,8 @@
if ( $property && array_key_exists( 'minimum_quantity',
$constraintParameters ) && array_key_exists( 'maximum_quantity',
$constraintParameters ) ) {
$min =
$constraintParameters['minimum_quantity'];
$max =
$constraintParameters['maximum_quantity'];
- $parameters['minimum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_quantity'] );
- $parameters['maximum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_quantity'] );
+ $parameters['minimum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['minimum_quantity'], true );
+ $parameters['maximum_quantity'] =
$this->constraintParameterParser->parseSingleParameter(
$constraintParameters['maximum_quantity'], true );
} else {
$message = wfMessage(
"wbqc-violation-message-parameter-needed" )->params(
$constraint->getConstraintTypeName(), 'property", "minimum_quantity" and
"maximum_quantity' )->escaped();
}
--
To view, visit https://gerrit.wikimedia.org/r/222080
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3c6a96670f7c4004e427af63441dfe4f387121c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: v1
Gerrit-Owner: Jonaskeutel <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
