jenkins-bot has submitted this change and it was merged.
Change subject: T103311 adapt escaping and comments in special page
......................................................................
T103311 adapt escaping and comments in special page
Change-Id: I8b01412ddfdfa6d2f992fe268e896ea8e062a135
---
M specials/SpecialViolationsPage.php
1 file changed, 14 insertions(+), 14 deletions(-)
Approvals:
Soeren.oldag: Looks good to me, approved
jenkins-bot: Verified
diff --git a/specials/SpecialViolationsPage.php
b/specials/SpecialViolationsPage.php
old mode 100644
new mode 100755
index 530ab82..d7ec952
--- a/specials/SpecialViolationsPage.php
+++ b/specials/SpecialViolationsPage.php
@@ -216,9 +216,9 @@
'div',
array( 'class' => 'wbq-violations-infobox' )
)
- . $this->msg( 'wbq-violations-explanations-general'
)->escaped()
+ . $this->msg( 'wbq-violations-explanations-general'
)->parse()
. Html::element( 'br' )
- . $this->msg( 'wbq-violations-explanations-exceptions'
)->escaped()
+ . $this->msg( 'wbq-violations-explanations-exceptions'
)->parse()
. Html::closeElement( 'div' );
return $infoBox;
@@ -332,7 +332,7 @@
'for' => $name,
'class' => 'wbq-violations-label'
),
- $this->msg( $labelMessage )->escaped()
+ $this->msg( $labelMessage )->text()
)
. Html::closeElement( 'div' )
. Html::openElement( 'div', array( 'class' =>
'wbq-violations-form-table-cell' ) )
@@ -564,12 +564,12 @@
private function buildViolationTable( array $violations ) {
$table = new HtmlTableBuilder(
array(
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-entity' )->escaped() ),
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-claim' )->escaped() ),
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-constraint-type' )->escaped() ),
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-status' )->escaped() ),
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-updated-at' )->escaped() ),
- new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-additional-info' )->escaped() )
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-entity' )->text() ),
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-claim' )->text() ),
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-constraint-type' )->text() ),
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-status' )->text() ),
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-updated-at' )->text() ),
+ new HtmlTableHeaderBuilder( $this->msg(
'wbq-violations-table-header-additional-info' )->text() )
)
);
@@ -591,7 +591,7 @@
new HtmlTableCellBuilder( $claim,
array(), true ),
new HtmlTableCellBuilder( $type,
array(), true ),
new HtmlTableCellBuilder( $status,
array(), true ),
- new HtmlTableCellBuilder( $updatedAt,
array(), true ),
+ new HtmlTableCellBuilder( $updatedAt,
array() ),
new HtmlTableCellBuilder(
$additionalInformation, array(), true )
)
);
@@ -650,7 +650,7 @@
* Additionally, if the current user is permitted, a link for marking
the violation as exception/violation is appended.
*
* @param Violation $violation
- * @return string
+ * @return string HTML
*/
private function formatStatus( Violation $violation ) {
$html = Html::element(
@@ -695,7 +695,7 @@
/**
* @param string $message
* @param bool $error
- * @return string
+ * @return string HTML
*/
private function buildNotice( $message, $error = false ) {
$cssClasses = 'wbq-violations-notice';
@@ -717,7 +717,7 @@
* @param Violation[] $violations
* @param bool $prevPageAvailable
* @param bool $nextPageAvailable
- * @return string
+ * @return string HTML
*/
private function buildPaginationControls( array $violations,
$prevPageAvailable, $nextPageAvailable ) {
$html = Html::openElement( 'p', array( 'class' =>
'wbq-violations-pagination' ) );
@@ -760,7 +760,7 @@
* @param string $contentMessage
* @param array $additionalQuery
* @param array $customAttribs
- * @return string
+ * @return string HTML
*/
private function buildPaginationLink( $contentMessage, array
$additionalQuery, array $customAttribs = array() ) {
$query = $this->getRequest()->getQueryValues();
--
To view, visit https://gerrit.wikimedia.org/r/220101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b01412ddfdfa6d2f992fe268e896ea8e062a135
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/WikibaseQuality
Gerrit-Branch: master
Gerrit-Owner: Dominic.sauer <[email protected]>
Gerrit-Reviewer: Soeren.oldag <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
