Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222218
Change subject: Add tool tip onboarding A/B testing
......................................................................
Add tool tip onboarding A/B testing
Bug: T89985
Change-Id: I457fbad65f7db8a6985a992aa435eb6ad6ee3f8f
---
M wikipedia/res/values/preference_keys.xml
M wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
M wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
M wikipedia/src/main/java/org/wikipedia/settings/Prefs.java
5 files changed, 27 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/18/222218/1
diff --git a/wikipedia/res/values/preference_keys.xml
b/wikipedia/res/values/preference_keys.xml
index 10bb64a..c499c32 100644
--- a/wikipedia/res/values/preference_keys.xml
+++ b/wikipedia/res/values/preference_keys.xml
@@ -12,13 +12,13 @@
<string name="preference_key_feedback">send_feedback</string>
<string name="preference_key_logout">log_out</string>
<string
name="preference_key_reading_app_install_id">readingAppInstallID</string>
- <string name="preference_key_feature_flag_id">featureFlagID</string>
<string
name="preference_key_text_size_multiplier">textSizeMultiplier</string>
<string name="preference_key_color_theme">colorTheme</string>
<string name="preference_key_app_channel">channel</string>
<string name="preference_key_language_mru">languageMru</string>
<string
name="preference_key_select_text_tutorial_enabled">selectTextTutorialEnabled</string>
<string
name="preference_key_share_tutorial_enabled">shareTutorialEnabled</string>
+ <string
name="preference_key_feature_select_text_and_share_tutorials_enabled">featureSelectTextAndShareTutorialsEnabled</string>
<string name="preference_key_know_toc_drawer">knowToC</string>
<string name="preference_key_show_images">showImages</string>
<string name="preference_key_exp_page_load">expPageLoad</string>
diff --git a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
index 95c8f02..684fe39 100644
--- a/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java
@@ -454,6 +454,15 @@
return enabled;
}
+ public boolean isFeatureSelectTextAndShareTutorialEnabled() {
+ if (Prefs.hasFeatureSelectTextAndShareTutorial()) {
+ return Prefs.isFeatureSelectTextAndShareTutorialEnabled();
+ }
+ boolean enabled = new Random().nextInt(2) == 0;
+ Prefs.setFeatureSelectTextAndShareTutorialEnabled(enabled);
+ return enabled;
+ }
+
/**
* Gets the currently-selected theme for the app.
* @return Theme that is currently selected, which is the actual theme ID
that can
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
index e803a2c..2b00ea4 100755
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragmentInternal.java
@@ -758,7 +758,9 @@
public void onPageLoadComplete() {
editHandler.setPage(model.getPage());
- if (model.getPage().isArticle() &&
app.getOnboardingStateMachine().isSelectTextTutorialEnabled()) {
+ if (app.isFeatureSelectTextAndShareTutorialEnabled()
+ && model.getPage().isArticle()
+ &&
app.getOnboardingStateMachine().isSelectTextTutorialEnabled()) {
showSelectTextOnboarding();
app.getOnboardingStateMachine().setSelectTextTutorial();
}
diff --git
a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
index 4eb9d1d..36b65de 100755
--- a/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/snippet/ShareHandler.java
@@ -194,7 +194,8 @@
|
MenuItemCompat.SHOW_AS_ACTION_WITH_TEXT);
}
- if
(WikipediaApp.getInstance().getOnboardingStateMachine().isShareTutorialEnabled())
{
+ if
(WikipediaApp.getInstance().isFeatureSelectTextAndShareTutorialEnabled()
+ &&
WikipediaApp.getInstance().getOnboardingStateMachine().isShareTutorialEnabled())
{
showShareOnboarding(shareItem);
WikipediaApp.getInstance().getOnboardingStateMachine().setShareTutorial();
}
diff --git a/wikipedia/src/main/java/org/wikipedia/settings/Prefs.java
b/wikipedia/src/main/java/org/wikipedia/settings/Prefs.java
index 04c96b1..5d8da67 100644
--- a/wikipedia/src/main/java/org/wikipedia/settings/Prefs.java
+++ b/wikipedia/src/main/java/org/wikipedia/settings/Prefs.java
@@ -235,6 +235,18 @@
setBoolean(R.string.preference_key_share_tutorial_enabled, enabled);
}
+ public static boolean isFeatureSelectTextAndShareTutorialEnabled() {
+ return
getBoolean(R.string.preference_key_feature_select_text_and_share_tutorials_enabled,
true);
+ }
+
+ public static void setFeatureSelectTextAndShareTutorialEnabled(boolean
enabled) {
+
setBoolean(R.string.preference_key_feature_select_text_and_share_tutorials_enabled,
enabled);
+ }
+
+ public static boolean hasFeatureSelectTextAndShareTutorial() {
+ return
contains(R.string.preference_key_feature_select_text_and_share_tutorials_enabled);
+ }
+
public static boolean isTocTutorialEnabled() {
return !getBoolean(R.string.preference_key_know_toc_drawer, false);
}
--
To view, visit https://gerrit.wikimedia.org/r/222218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I457fbad65f7db8a6985a992aa435eb6ad6ee3f8f
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
