Hello Mobrovac,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/222261
to review the following change.
Change subject: Inject npm devDependencies into deploy.git node_modules
......................................................................
Inject npm devDependencies into deploy.git node_modules
The mediawiki/services/*/deploy.git repo lacks devDependencies since we
do not need them for production usage. To run tests, we need them
though.
Use Marko script to read the devdependencies and install them on top of
the deploy.git provided node_modules. Will bring us all the test
utilities we need.
Signed-off-by: Marko Obrovac <[email protected]>
Change-Id: I7e9b07606d2655d827c810ac98437e1efec2171c
---
M jjb/macro.yaml
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/config
refs/changes/61/222261/1
diff --git a/jjb/macro.yaml b/jjb/macro.yaml
index 109a264..bb5193d 100644
--- a/jjb/macro.yaml
+++ b/jjb/macro.yaml
@@ -110,7 +110,11 @@
node --version
npm --version
. npm-oid.env
- cd "$NPM_SET_PATH"
+
+ echo "Injecting dev dependencies from source repo into deploy
node_modules"
+ /srv/deployment/integration/slave-scripts/bin/npm-install-dev.py
+
+ cd "$NPM_SET_PATH" # for deploy: ./src
npm test
# MUST run 'global-setup' before this
--
To view, visit https://gerrit.wikimedia.org/r/222261
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e9b07606d2655d827c810ac98437e1efec2171c
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
