Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/222585

Change subject: Unify whitespace in array() functions
......................................................................

Unify whitespace in array() functions

How did I missed these in I038a0f4? I was sure I did a regex search
for these.

Change-Id: I03b0d9863e5bde22d4d2df98e4ceeb3e6e48e857
---
M 
client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php
M lib/tests/phpunit/entity/EntityFactoryTest.php
M repo/includes/ChangePruner.php
M repo/includes/Diff/EntityDiffVisualizer.php
M repo/includes/store/sql/DispatchStats.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpAliasesTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpDescriptionTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpLabelTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpRemoveStatementTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php
M repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php
M repo/tests/phpunit/includes/IO/EntityIdReaderTest.php
M repo/tests/phpunit/includes/Validators/SnakValidatorTest.php
M repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
20 files changed, 59 insertions(+), 59 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/85/222585/1

diff --git 
a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php
 
b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php
index a7c56ba..c2eed75 100644
--- 
a/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php
+++ 
b/client/tests/phpunit/includes/DataAccess/PropertyParserFunction/VariantsAwareRendererTest.php
@@ -60,7 +60,7 @@
                        array(
                                
'-{zh:mooooo;zh-hans:mooooo;zh-hant:mooooo;zh-cn:mooooo;zh-hk:mooooo;}-',
                                $itemId,
-                               array ( 'zh', 'zh-hans', 'zh-hant', 'zh-cn', 
'zh-hk' ),
+                               array( 'zh', 'zh-hans', 'zh-hant', 'zh-cn', 
'zh-hk' ),
                                'cat'
                        ),
                        // Don't create "-{}-" for empty input,
diff --git a/lib/tests/phpunit/entity/EntityFactoryTest.php 
b/lib/tests/phpunit/entity/EntityFactoryTest.php
index c8f783e..c7b5aab 100644
--- a/lib/tests/phpunit/entity/EntityFactoryTest.php
+++ b/lib/tests/phpunit/entity/EntityFactoryTest.php
@@ -35,10 +35,10 @@
                $tests = array();
 
                foreach ( $this->getEntityFactory()->getEntityTypes() as $type 
) {
-                       $tests[] = array ( $type, true );
+                       $tests[] = array( $type, true );
                }
 
-               $tests[] = array ( 'this-does-not-exist', false );
+               $tests[] = array( 'this-does-not-exist', false );
 
                return $tests;
        }
diff --git a/repo/includes/ChangePruner.php b/repo/includes/ChangePruner.php
index 91946e2..8a3e438 100644
--- a/repo/includes/ChangePruner.php
+++ b/repo/includes/ChangePruner.php
@@ -89,7 +89,7 @@
                if ( !$this->ignoreDispatch ) {
                        $dbr = wfGetDB( DB_SLAVE );
                        $row = $dbr->selectRow(
-                               array ( 'wb_changes_dispatch', 'wb_changes' ),
+                               array( 'wb_changes_dispatch', 'wb_changes' ),
                                'min(change_time) as timestamp',
                                array(
                                        'chd_disabled' => 0,
diff --git a/repo/includes/Diff/EntityDiffVisualizer.php 
b/repo/includes/Diff/EntityDiffVisualizer.php
index 49a85dd..f8fdc4e 100644
--- a/repo/includes/Diff/EntityDiffVisualizer.php
+++ b/repo/includes/Diff/EntityDiffVisualizer.php
@@ -109,7 +109,7 @@
                $termDiffVisualizer = new DiffView(
                        array(),
                        new Diff(
-                               array (
+                               array(
                                        
$this->context->getLanguage()->getMessage( 'wikibase-diffview-label' ) => 
$diff->getLabelsDiff(),
                                        
$this->context->getLanguage()->getMessage( 'wikibase-diffview-alias' ) => 
$diff->getAliasesDiff(),
                                        
$this->context->getLanguage()->getMessage( 'wikibase-diffview-description' ) => 
$diff->getDescriptionsDiff(),
@@ -132,7 +132,7 @@
                        $linkDiffVisualizer = new DiffView(
                                array(),
                                new Diff(
-                                       array (
+                                       array(
                                                
$this->context->getLanguage()->getMessage( 'wikibase-diffview-link' ) => 
$diff->getSiteLinkDiff(),
                                        ),
                                        true
diff --git a/repo/includes/store/sql/DispatchStats.php 
b/repo/includes/store/sql/DispatchStats.php
index 2046c47..763a781 100644
--- a/repo/includes/store/sql/DispatchStats.php
+++ b/repo/includes/store/sql/DispatchStats.php
@@ -55,7 +55,7 @@
                );
 
                $res = $db->select(
-                       array (
+                       array(
                                'wb_changes_dispatch',
                                'wb_changes'
                        ),
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpAliasesTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpAliasesTest.php
index 8f7ecef..811aaaa 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpAliasesTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpAliasesTest.php
@@ -54,7 +54,7 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $enAliases = array( 'en-alias1', 'en-alias2', 'en-alias3' );
-               $existingEnAliases = array ( 'en-existingAlias1', 
'en-existingAlias2' );
+               $existingEnAliases = array( 'en-existingAlias1', 
'en-existingAlias2' );
                $item = ItemContent::newEmpty();
                $entity = $item->getEntity();
                $entity->setAliases( 'en', $existingEnAliases );
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpDescriptionTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpDescriptionTest.php
index ab7e69c..9f5048d 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpDescriptionTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpDescriptionTest.php
@@ -43,8 +43,8 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $args = array();
-               $args['update'] = array ( new ChangeOpDescription( 'en', 
'myNew', $validatorFactory ), 'myNew' );
-               $args['set to null'] = array ( new ChangeOpDescription( 'en', 
null, $validatorFactory ), '' );
+               $args['update'] = array( new ChangeOpDescription( 'en', 
'myNew', $validatorFactory ), 'myNew' );
+               $args['set to null'] = array( new ChangeOpDescription( 'en', 
null, $validatorFactory ), '' );
 
                return $args;
        }
@@ -69,11 +69,11 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $args = array();
-               $args['valid description'] = array ( new ChangeOpDescription( 
'fr', 'valid', $validatorFactory ), true );
-               $args['invalid description'] = array ( new ChangeOpDescription( 
'fr', 'INVALID', $validatorFactory ), false );
-               $args['duplicate description'] = array ( new 
ChangeOpDescription( 'fr', 'DUPE', $validatorFactory ), false );
-               $args['invalid language'] = array ( new ChangeOpDescription( 
'INVALID', 'valid', $validatorFactory ), false );
-               $args['set bad language to null'] = array ( new 
ChangeOpDescription( 'INVALID', null, $validatorFactory ), false );
+               $args['valid description'] = array( new ChangeOpDescription( 
'fr', 'valid', $validatorFactory ), true );
+               $args['invalid description'] = array( new ChangeOpDescription( 
'fr', 'INVALID', $validatorFactory ), false );
+               $args['duplicate description'] = array( new 
ChangeOpDescription( 'fr', 'DUPE', $validatorFactory ), false );
+               $args['invalid language'] = array( new ChangeOpDescription( 
'INVALID', 'valid', $validatorFactory ), false );
+               $args['set bad language to null'] = array( new 
ChangeOpDescription( 'INVALID', null, $validatorFactory ), false );
 
                return $args;
        }
@@ -115,15 +115,15 @@
 
                $entity = $this->provideNewEntity();
                $entity->setDescription( 'de', 'Test' );
-               $args[] = array ( $entity, new ChangeOpDescription( 'de', 
'Zusammenfassung', $validatorFactory ), 'set', 'de' );
+               $args[] = array( $entity, new ChangeOpDescription( 'de', 
'Zusammenfassung', $validatorFactory ), 'set', 'de' );
 
                $entity = $this->provideNewEntity();
                $entity->setDescription( 'de', 'Test' );
-               $args[] = array ( $entity, new ChangeOpDescription( 'de', null, 
$validatorFactory ), 'remove', 'de' );
+               $args[] = array( $entity, new ChangeOpDescription( 'de', null, 
$validatorFactory ), 'remove', 'de' );
 
                $entity = $this->provideNewEntity();
                $entity->removeDescription( 'de' );
-               $args[] = array ( $entity, new ChangeOpDescription( 'de', 
'Zusammenfassung', $validatorFactory ), 'add', 'de' );
+               $args[] = array( $entity, new ChangeOpDescription( 'de', 
'Zusammenfassung', $validatorFactory ), 'add', 'de' );
 
                return $args;
        }
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpLabelTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpLabelTest.php
index b3319f5..9de6652 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpLabelTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpLabelTest.php
@@ -43,8 +43,8 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $args = array();
-               $args['update'] = array ( new ChangeOpLabel( 'en', 'myNew', 
$validatorFactory ), 'myNew' );
-               $args['set to null'] = array ( new ChangeOpLabel( 'en', null, 
$validatorFactory ), '' );
+               $args['update'] = array( new ChangeOpLabel( 'en', 'myNew', 
$validatorFactory ), 'myNew' );
+               $args['set to null'] = array( new ChangeOpLabel( 'en', null, 
$validatorFactory ), '' );
 
                return $args;
        }
@@ -69,11 +69,11 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $args = array();
-               $args['valid label'] = array ( new ChangeOpLabel( 'fr', 
'valid', $validatorFactory ), true );
-               $args['invalid label'] = array ( new ChangeOpLabel( 'fr', 
'INVALID', $validatorFactory ), false );
-               $args['duplicate label'] = array ( new ChangeOpLabel( 'fr', 
'DUPE', $validatorFactory ), false );
-               $args['invalid language'] = array ( new ChangeOpLabel( 
'INVALID', 'valid', $validatorFactory ), false );
-               $args['set bad language to null'] = array ( new ChangeOpLabel( 
'INVALID', null, $validatorFactory ), false );
+               $args['valid label'] = array( new ChangeOpLabel( 'fr', 'valid', 
$validatorFactory ), true );
+               $args['invalid label'] = array( new ChangeOpLabel( 'fr', 
'INVALID', $validatorFactory ), false );
+               $args['duplicate label'] = array( new ChangeOpLabel( 'fr', 
'DUPE', $validatorFactory ), false );
+               $args['invalid language'] = array( new ChangeOpLabel( 
'INVALID', 'valid', $validatorFactory ), false );
+               $args['set bad language to null'] = array( new ChangeOpLabel( 
'INVALID', null, $validatorFactory ), false );
 
                return $args;
        }
@@ -115,15 +115,15 @@
 
                $entity = $this->provideNewEntity();
                $entity->getFingerprint()->setLabel( 'de', 'Test' );
-               $args[] = array ( $entity, new ChangeOpLabel( 'de', 
'Zusammenfassung', $validatorFactory ), 'set', 'de' );
+               $args[] = array( $entity, new ChangeOpLabel( 'de', 
'Zusammenfassung', $validatorFactory ), 'set', 'de' );
 
                $entity = $this->provideNewEntity();
                $entity->getFingerprint()->setLabel( 'de', 'Test' );
-               $args[] = array ( $entity, new ChangeOpLabel( 'de', null, 
$validatorFactory ), 'remove', 'de' );
+               $args[] = array( $entity, new ChangeOpLabel( 'de', null, 
$validatorFactory ), 'remove', 'de' );
 
                $entity = $this->provideNewEntity();
                $entity->removeLabel( 'de' );
-               $args[] = array ( $entity, new ChangeOpLabel( 'de', 
'Zusammenfassung', $validatorFactory
+               $args[] = array( $entity, new ChangeOpLabel( 'de', 
'Zusammenfassung', $validatorFactory
                ), 'add', 'de' );
 
                return $args;
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php
index 80154d6..b9658a4 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpMainSnakTest.php
@@ -99,7 +99,7 @@
                $guid = '';
                $changeOp = $this->newChangeOpMainSnak( $guid, $newSnak );
                $expected = $newSnak->getDataValue();
-               $args['add new claim'] = array ( $item, $changeOp, $expected );
+               $args['add new claim'] = array( $item, $changeOp, $expected );
 
                // update an existing claim with a new main snak value
                $item = $this->makeNewItemWithClaim( 'Q234', $snak );
@@ -110,7 +110,7 @@
                $guid = $claim->getGuid();
                $changeOp = $this->newChangeOpMainSnak( $guid, $newSnak );
                $expected = $newSnak->getDataValue();
-               $args['update claim by guid'] = array ( $item, $changeOp, 
$expected );
+               $args['update claim by guid'] = array( $item, $changeOp, 
$expected );
 
                return $args;
        }
@@ -140,11 +140,11 @@
                // apply change to the wrong item
                $wrongItem = new Item( new ItemId( 'Q888' ) );
                $newSnak =  $this->makeSnak( 'P12', 'newww' );
-               $args['wrong entity'] = array ( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $newSnak ) );
+               $args['wrong entity'] = array( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $newSnak ) );
 
                // apply change to an unknown claim
                $wrongClaimId = $item->getId()->getSerialization() . 
'$DEADBEEF-DEAD-BEEF-DEAD-BEEFDEADBEEF';
-               $args['unknown claim'] = array ( $item, 
$this->newChangeOpMainSnak( $wrongClaimId, $newSnak ) );
+               $args['unknown claim'] = array( $item, 
$this->newChangeOpMainSnak( $wrongClaimId, $newSnak ) );
 
                // update an existing claim with wrong main snak property
                $newSnak =  $this->makeSnak( 'P13', 'changedSnak' );
@@ -154,16 +154,16 @@
 
                $guid = $statement->getGuid();
                $changeOp = $this->newChangeOpMainSnak( $guid, $newSnak );
-               $args['wrong main snak property'] = array ( $item, $changeOp );
+               $args['wrong main snak property'] = array( $item, $changeOp );
 
                // apply invalid main snak
                $badSnak =  $this->makeSnak( 'P12', new NumberValue( 5 ) );
-               $args['bad value type'] = array ( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $badSnak ) );
+               $args['bad value type'] = array( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $badSnak ) );
 
                // apply invalid main snak
                // NOTE: the mock validator considers "INVALID" to be invalid.
                $badSnak = $this->makeSnak( 'P12', 'INVALID' );
-               $args['invalid value'] = array ( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $badSnak ) );
+               $args['invalid value'] = array( $wrongItem, 
$this->newChangeOpMainSnak( $guid, $badSnak ) );
 
                return $args;
        }
diff --git 
a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
index 63838f3..02c0e15 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierRemoveTest.php
@@ -51,7 +51,7 @@
                $statement->getQualifiers()->addSnak( $newQualifier );
                $snakHash = $newQualifier->getHash();
                $changeOp = new ChangeOpQualifierRemove( $guid, $snakHash );
-               $args[] = array ( $item, $changeOp, $snakHash );
+               $args[] = array( $item, $changeOp, $snakHash );
 
                return $args;
        }
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php
index 47db407..8fac099 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpQualifierTest.php
@@ -83,7 +83,7 @@
                $newQualifier = new PropertyValueSnak( 78462378, new 
StringValue( 'newQualifier' ) );
                $changeOp = new ChangeOpQualifier( $guid, $newQualifier, '', 
$this->mockProvider->getMockSnakValidator() );
                $snakHash = $newQualifier->getHash();
-               $args[] = array ( $item, $changeOp, $snakHash );
+               $args[] = array( $item, $changeOp, $snakHash );
 
                return $args;
        }
@@ -114,7 +114,7 @@
                $snakHash = $newQualifier->getHash();
                $changedQualifier = new PropertyValueSnak( 78462378, new 
StringValue( 'changedQualifier' ) );
                $changeOp = new ChangeOpQualifier( $guid, $changedQualifier, 
$snakHash, $this->mockProvider->getMockSnakValidator() );
-               $args[] = array ( $item, $changeOp, 
$changedQualifier->getHash() );
+               $args[] = array( $item, $changeOp, $changedQualifier->getHash() 
);
 
                return $args;
        }
diff --git 
a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
index 81b7b82..64b3642 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceRemoveTest.php
@@ -55,7 +55,7 @@
                $statement->getReferences()->addReference( $newReference );
                $referenceHash = $newReference->getHash();
                $changeOp = new ChangeOpReferenceRemove( $guid, $referenceHash 
);
-               $args[ 'Removing a single reference' ] = array ( $item, 
$changeOp, $referenceHash );
+               $args[ 'Removing a single reference' ] = array( $item, 
$changeOp, $referenceHash );
 
                $item = $this->newItemWithClaim( 'q346', $snak );
                $statements = $item->getStatements()->toArray();
@@ -70,7 +70,7 @@
                $references->addReference( $newReference );
                $referenceHash = $newReference->getHash();
                $changeOp = new ChangeOpReferenceRemove( $guid, $referenceHash 
);
-               $args[ 'Removing references that have the same hash' ] = array 
( $item, $changeOp, $referenceHash );
+               $args[ 'Removing references that have the same hash' ] = array( 
$item, $changeOp, $referenceHash );
 
                return $args;
        }
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php
index 276b5b2..73d8bb7 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpReferenceTest.php
@@ -88,7 +88,7 @@
                $newReference = new Reference( $snaks );
                $changeOp = new ChangeOpReference( $guid, $newReference, '', 
$this->mockProvider->getMockSnakValidator() );
                $referenceHash = $newReference->getHash();
-               $args[] = array ( $item, $changeOp, $referenceHash );
+               $args[] = array( $item, $changeOp, $referenceHash );
 
                return $args;
        }
@@ -134,7 +134,7 @@
                        $newReferenceIndex
                );
 
-               $args[] = array ( $item, $changeOp, $newReference, 
$newReferenceIndex );
+               $args[] = array( $item, $changeOp, $newReference, 
$newReferenceIndex );
 
                return $args;
        }
@@ -174,7 +174,7 @@
                $snaks[] = new PropertyValueSnak( 78462378, new StringValue( 
'changedQualifier' ) );
                $changedReference = new Reference( $snaks );
                $changeOp = new ChangeOpReference( $guid, $changedReference, 
$referenceHash, $this->mockProvider->getMockSnakValidator() );
-               $args[] = array ( $item, $changeOp, 
$changedReference->getHash() );
+               $args[] = array( $item, $changeOp, $changedReference->getHash() 
);
 
                // Just change a reference's index:
                $item = $this->newItemWithClaim( $snak );
@@ -199,7 +199,7 @@
                        $this->mockProvider->getMockSnakValidator(),
                        0
                );
-               $args[] = array ( $item, $changeOp, $references[1]->getHash() );
+               $args[] = array( $item, $changeOp, $references[1]->getHash() );
 
                return $args;
        }
diff --git 
a/repo/tests/phpunit/includes/ChangeOp/ChangeOpRemoveStatementTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpRemoveStatementTest.php
index 975546a..5e693c2 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpRemoveStatementTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpRemoveStatementTest.php
@@ -56,7 +56,7 @@
                $guid = $statement->getGuid();
                $changeOp = new ChangeOpRemoveStatement( $guid );
                $expected = null;
-               $args[] = array ( $item, $changeOp, $expected );
+               $args[] = array( $item, $changeOp, $expected );
 
                return $args;
        }
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
index 287ab0e..7dfb8be 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpSiteLinkTest.php
@@ -81,7 +81,7 @@
                $args[] = array(
                        $item->copy(),
                        new ChangeOpSiteLink( 'enwiki', 'Berlin', array( new 
ItemId( 'Q149' ) ) ),
-                       array_merge( $existingSiteLinks, array ( $enSiteLink ) )
+                       array_merge( $existingSiteLinks, array( $enSiteLink ) )
                );
 
                // deleting sitelink
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php
index a0f6678..3863d78 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpStatementRankTest.php
@@ -59,7 +59,7 @@
 
                $changeOp = new ChangeOpStatementRank( $guid, $rank );
 
-               $args[] = array ( $item, $changeOp, $rank );
+               $args[] = array( $item, $changeOp, $rank );
 
                return $args;
        }
diff --git a/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php 
b/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php
index e90ec95..137edb8 100644
--- a/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php
+++ b/repo/tests/phpunit/includes/ChangeOp/ChangeOpsTest.php
@@ -46,9 +46,9 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $ops = array();
-               $ops[] = array ( new ChangeOpLabel( 'en', 'myNewLabel', 
$validatorFactory ) );
-               $ops[] = array ( new ChangeOpDescription( 'de', 
'myNewDescription', $validatorFactory ) );
-               $ops[] = array ( new ChangeOpLabel( 'en', null, 
$validatorFactory ) );
+               $ops[] = array( new ChangeOpLabel( 'en', 'myNewLabel', 
$validatorFactory ) );
+               $ops[] = array( new ChangeOpDescription( 'de', 
'myNewDescription', $validatorFactory ) );
+               $ops[] = array( new ChangeOpLabel( 'en', null, 
$validatorFactory ) );
 
                return $ops;
        }
@@ -68,7 +68,7 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $ops = array();
-               $ops[] = array (
+               $ops[] = array(
                                        array(
                                                new ChangeOpLabel( 'en', 
'enLabel', $validatorFactory ),
                                                new ChangeOpLabel( 'de', 
'deLabel', $validatorFactory ),
@@ -94,8 +94,8 @@
                $validatorFactory = $this->getTermValidatorFactory();
 
                $ops = array();
-               $ops[] = array ( 1234 );
-               $ops[] = array ( array( new ChangeOpLabel( 'en', 'test', 
$validatorFactory ), 123 ) );
+               $ops[] = array( 1234 );
+               $ops[] = array( array( new ChangeOpLabel( 'en', 'test', 
$validatorFactory ), 123 ) );
 
                return $ops;
        }
diff --git a/repo/tests/phpunit/includes/IO/EntityIdReaderTest.php 
b/repo/tests/phpunit/includes/IO/EntityIdReaderTest.php
index 8086c12..5237903 100644
--- a/repo/tests/phpunit/includes/IO/EntityIdReaderTest.php
+++ b/repo/tests/phpunit/includes/IO/EntityIdReaderTest.php
@@ -107,7 +107,7 @@
                                'EntityIdReaderTest.txt',
                                null,
                                2,
-                               array (
+                               array(
                                        array( $q1, $p2 ),
                                        array( $q3, $p4 ),
                                        array(),
diff --git a/repo/tests/phpunit/includes/Validators/SnakValidatorTest.php 
b/repo/tests/phpunit/includes/Validators/SnakValidatorTest.php
index 9c48357..256bd01 100644
--- a/repo/tests/phpunit/includes/Validators/SnakValidatorTest.php
+++ b/repo/tests/phpunit/includes/Validators/SnakValidatorTest.php
@@ -99,7 +99,7 @@
                $claim->setQualifiers( new SnakList( array(
                        new PropertyValueSnak( $p2, new StringValue( 'abc' ) )
                ) ) );
-               $claim->setReferences( new ReferenceList( array (
+               $claim->setReferences( new ReferenceList( array(
                        new Reference( new SnakList( array(
                                new PropertyValueSnak( $p2, new StringValue( 
'xyz' ) )
                        ) ) )
@@ -119,7 +119,7 @@
                $cases[] = array( $brokenClaim, 'error in qualifier', false );
 
                $brokenClaim = clone $claim;
-               $brokenClaim->setReferences( new ReferenceList( array (
+               $brokenClaim->setReferences( new ReferenceList( array(
                        new Reference( new SnakList( array(
                                new PropertyValueSnak( $p1, new StringValue( 
'xyz' ) )
                        ) ) )
@@ -149,7 +149,7 @@
                $references = new ReferenceList();
                $cases[] = array( $references, 'empty reference list', true );
 
-               $references = new ReferenceList( array (
+               $references = new ReferenceList( array(
                        new Reference( new SnakList( array(
                                new PropertyValueSnak( $p1, new StringValue( 
'123' ) )
                        ) ) ),
@@ -159,7 +159,7 @@
                ) );
                $cases[] = array( $references, 'conforming reference list', 
true );
 
-               $references = new ReferenceList( array (
+               $references = new ReferenceList( array(
                        new Reference( new SnakList( array(
                                new PropertyValueSnak( $p1, new StringValue( 
'123' ) )
                        ) ) ),
diff --git a/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php 
b/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
index 3810a98..22dd128 100644
--- a/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
+++ b/repo/tests/phpunit/includes/specials/SpecialMergeItemsTest.php
@@ -257,7 +257,7 @@
                        array( 'claims' => array( 'P1' => array( $statement ) ) 
),
                        array(),
                        array(),
-                       array( 'claims' => array( 'P1' => array ( 
$statementWithoutId ) ) ),
+                       array( 'claims' => array( 'P1' => array( 
$statementWithoutId ) ) ),
                );
 
                return $testCases;

-- 
To view, visit https://gerrit.wikimedia.org/r/222585
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03b0d9863e5bde22d4d2df98e4ceeb3e6e48e857
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to