Sumit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/222693
Change subject: WikidataPageBanner fixes for skin Minerva
......................................................................
WikidataPageBanner fixes for skin Minerva
Introduced the following css changes for skin Minerva:
* precontent <h1> made to hide
* extra margin-top given to topbanner to prevent overlapping with edit buttons.
* .banner-image class renamed to .wpb-banner-image class because
MobileFrontend's banner module also uses the same class.
* Reduce banner name font to 1em when screen below 768px
Bug: T98034
Change-Id: Iaab674cc216110fa2b59348e0a3add7e2c001654
---
M resources/Resources.php
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
A resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.mobile.less
M resources/ext.WikidataPageBanner.toc/ext.WikidataPageBanner.toc.less
M templates/banner.mustache
5 files changed, 29 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner
refs/changes/93/222693/1
diff --git a/resources/Resources.php b/resources/Resources.php
index 1fecc55..cdf02ef 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -28,6 +28,9 @@
'styles' => array(
'ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less',
),
+ 'skinStyles' => array(
+ 'minerva' =>
'ext.WikidataPageBanner.styles/ext.WikidataPageBanner.mobile.less'
+ ),
'localBasePath' => __DIR__,
'remoteExtPath' => 'WikidataPageBanner/resources',
'targets' => array( 'desktop', 'mobile' ),
diff --git
a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
index 3b6fd8e..4abd59a 100644
--- a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
+++ b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
@@ -10,6 +10,7 @@
position: relative;
max-width: 1800px;
height: auto;
+ margin: 1em 0;
}
.topbanner .name {
@@ -30,7 +31,7 @@
display: none;
}
-.topbanner .banner-image{
+.topbanner .wpb-banner-image{
width: 100%;
height: auto;
}
@@ -49,3 +50,9 @@
float: left;
}
}
+
+@media screen and ( max-width: 768px ) {
+ .topbanner .name {
+ font-size: 1em;
+ }
+}
diff --git
a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.mobile.less
b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.mobile.less
new file mode 100644
index 0000000..52673dc
--- /dev/null
+++ b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.mobile.less
@@ -0,0 +1,12 @@
+/**
+ * Stylesheet for page-wide Banner in WikidataPageBanner extension.
+ */
+@import "mediawiki.mixins";
+.topbanner{
+ // since h1 is hidden so give extra margin to prevent overlapping with
edit buttons
+ margin: 3em 0 1em 0;
+}
+
+.pre-content h1 {
+ display: none;
+}
diff --git
a/resources/ext.WikidataPageBanner.toc/ext.WikidataPageBanner.toc.less
b/resources/ext.WikidataPageBanner.toc/ext.WikidataPageBanner.toc.less
index 1924c14..59f11bf 100644
--- a/resources/ext.WikidataPageBanner.toc/ext.WikidataPageBanner.toc.less
+++ b/resources/ext.WikidataPageBanner.toc/ext.WikidataPageBanner.toc.less
@@ -105,4 +105,9 @@
#toctitle {
display: none;
}
+
+ // hide toc if toc module added and screen is large
+ .toc-mobile, .toc {
+ display: none;
+ }
}
diff --git a/templates/banner.mustache b/templates/banner.mustache
index 47e2d32..a6e6ed7 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -2,7 +2,7 @@
<div class="ext-wpb-pagebanner">
<div class="topbanner">
<div class="name">{{title}}</div>
- <a title="{{tooltip}}" href={{bannerfile}}><img
src={{banner}} srcset="{{srcset}}" class="banner-image"></a>
+ <a title="{{tooltip}}" href={{bannerfile}}><img
src={{banner}} srcset="{{srcset}}" class="wpb-banner-image"></a>
<div class="iconbox">
{{#icons}}
{{{icon}}}
--
To view, visit https://gerrit.wikimedia.org/r/222693
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaab674cc216110fa2b59348e0a3add7e2c001654
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
